1226559 - Twitter pings are broken

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[aleth [:aleth]]

Apparently twitter pings are broken.

Comment 1

[aleth [:aleth]]

Attachment: Fix twitter @mention pings

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8690033 [details] [diff] [review]
Fix twitter @mention pings

Review of attachment 8690033 [details] [diff] [review]:
-----------------------------------------------------------------

Any idea what broke this? (Perhaps rendering mentions in a bubble?)

::: chat/protocols/twitter/twitter.js
@@ +353,5 @@
>        flags.delayed = true;
> +    if (aTweet.entities && aTweet.entities.user_mentions &&
> +        Array.isArray(aTweet.entities.user_mentions) &&
> +        aTweet.entities.user_mentions.map(mention => mention.screen_name)
> +                                     .some(name => name == this.nick))

This looks good. I think I'd combine the .map and .some into a single call, but isn't necessary for r+:

.some(mention => mention.screen_name == this.nick)

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/a69b34c19f9a63a1e882186dc20169ee2164c1b2
Bug 1226559 - Fix twitter @mention pings. r=clokep

Comment 4

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> Comment on attachment 8690033 [details] [diff] [review]
> Fix twitter @mention pings
> 
> Review of attachment 8690033 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Any idea what broke this? (Perhaps rendering mentions in a bubble?)

Yes, exactly (there's a <span> after that's inserted).

.map removed on checkin