1218222 - Autophone - migrate to using per-user Hawk credentials for Treeherder

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

We need to transition from the old system of specifying credentials to the new per-user Hawk credentials.

Comment 1

[Ed Morley [:emorley]]

To use the new credentials, you'll need treeherder-client>=1.8.0

When transitioning from treeherder-client 1.6.0 to 1.8.0, add_build_url() no longer exists, so the call here will need to be removed:
https://github.com/mozilla/autophone/blob/3a896456a8128f755de1a73aaafd15f3c5598d6f/autophonetreeherder.py#L173

Comment 2

[Ed Morley [:emorley]]

The TreeherderAuth class no longer exists, so references to that need to be removed:
https://github.com/mozilla/autophone/blob/3a896456a8128f755de1a73aaafd15f3c5598d6f/autophonetreeherder.py#L84-L86
...and instead the client_id and secret (which are the same for all repositories) passed to TreeherderClient like so:
http://treeherder.readthedocs.org/submitting_data.html#authentication

Hope that helps :-)

Comment 3

[Ed Morley [:emorley]]

Attachment: Submit results to Treeherder's API using Hawk credentials

Before this merges, the credentials file will need to have top-level "client_id" and "secret" keys added. Once this is in production, the old per-repo credentials can then be removed from the credentials file.

Comment 4

[Bob Clary [:bc] (inactive)]

Ed: Thanks for this. There is additional work that will need to be done to change the autophone.py command line options, how the options are handled and how the credentials are handled. The treeherder credentials file will go away and the client_id and secret will be kept in the same credentials ini file as s3, phonedash and pulse.

Do you want to carry this over the finish line or would you like me to complete it? This is a great start and I really appreciate it. I can make the necessary changes and test them out and deploy Monday if that fits with your schedule.

Hawk credentials are supported on Treeherder staging and production right now?

I don't believe autophone.qa.mtv2.mozilla.com/10.252.73.89 has access to server 10.22.75.4{0,1} so we will need to get the network acls opened up for the QA lab if we need to fix the time on the host. Currently the autophone host is running 10.8.5 and is accurately synced on time. In the near future it will be moving to Linux. I don't think we need worry about the time.

Comment 5

[Ed Morley [:emorley]]

You're welcome :-)

Happy for you to take over to do the refactor.

Hawk auth is supported on stage+prod at the moment. I've marked your prod and stage credentials as approved; though I've renamed both to `autophone` to match the others, since we don't need to namespace for stage/prod since they are entirely different credentials systems.

Let me know if there's anything more I can do to help.

Comment 6

[Ed Morley [:emorley]]

Changed the staging client_id to autophone_bclary , since they are used for local development (and so per-user) rather than an official autophone staging instance (like taskcluster uses etc).

Comment 7

[Bob Clary [:bc] (inactive)]

Comment on attachment 8681298 [details] [review]
Submit results to Treeherder's API using Hawk credentials

I made some changes in a follow up, but this looks good.

Comment 8

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/autophone/pull/48

jmaher: Just review my patch. Ed's are covered in the previous PR.

test run: https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=b0a8ab5e0856&exclusion_profile=false&filter-searchStr=autophone

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8682049 [details] [review]
https://github.com/mozilla/autophone/pull/48

lots of cleanup on cli text!  I am not 100% certain of the treeherder client usage, the logic and code looks pretty good.

Comment 10

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/02ce3d383e2c60bd3cb464187c5a00f2ceb09210
https://github.com/mozilla/autophone/commit/c7d083506413781c058b2c791ec1e73086861a83
https://github.com/mozilla/autophone/commit/708683b8fc3af20d20b3312046e88dbd93da2368
https://github.com/mozilla/autophone/commit/8c880012c4fe3a8972e822c17deecfa188d6a06e

Ed, this won't be active on the production server until we deploy the changes.

Comment 11

[Bob Clary [:bc] (inactive)]

Attachment: treeherder-client 1.8.0 upgrade log