1218227 - Make fetch-request-css-base-url-worker.js pass

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, defect, P3)

Description

[(no longer active)]

This test seems to have a bug in it that is causing it to fail!

Comment 1

[(no longer active)]

Attachment: Make fetch-request-css-base-url-worker.js pass

Comment 2

[Josh Matthews [:jdm]]

This doesn't look right. The point of the test is that the request for the CSS file is rewritten to use the other origin, right?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8678620 [details] [diff] [review]
Make fetch-request-css-base-url-worker.js pass

Review of attachment 8678620 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Josh, this is not right.

Whats happening here is our opaque tainting fake redirect is changing the stylesheet URL.  We need bug 1201160 to fix this (as noted in the wpt ini file).

Comment 4

[(no longer active)]

Oh, right, sorry I was misreading the test!

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

I think the correct fix here is to implement bug 1222008.  We will then propagate back the final URL correctly.

Bug 1201160 would instead make us not get intercepted at all, but I don't think that's what chrome is doing today either.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Bug 1735089 was the wpt sync that noticed we weren't failing this anymore. We still have OK/TIMEOUT for android but we no longer fail, resolving WFM.