Size of files not displayed in "about:downloads" after restarting Firefox

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
Download Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u421692, Assigned: JanH, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox41 affected, firefox42 affected, firefox43 affected, firefox44 affected, firefox48 fixed, fennec+)

Details

(Whiteboard: [lang=js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8678724 [details]
device-2015-10-26-105504.png

Steps to reproduce:
1. Download a file, check download manager
2. Restart Firefox, check download manager

Expected result:
1. Only one figure is displayed after the decimal separator for file size
2. Size of file is correctly displayed

Actual result:
1. Fourteen figures are displayed after the decimal separator for file size
2. Size of file is not displayed (unknown size) 

PS:
The issue whit the figures after the decimal separator is not reproducing on Firefox 41.0.2
tracking-fennec: --- → ?

Comment 1

2 years ago
You should take a look in the code here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutDownloads.js
Mentor: margaret.leibovic@gmail.com
Whiteboard: [lang=js]

Updated

2 years ago
tracking-fennec: ? → +
(Assignee)

Updated

2 years ago
Assignee: nobody → jh+bugzilla
(Assignee)

Comment 2

2 years ago
Created attachment 8742471 [details]
MozReview Request: Bug 1218317 - Retrieve the file size for finished downloads. r=margaret

Review commit: https://reviewboard.mozilla.org/r/47215/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47215/
Attachment #8742471 - Flags: review?(margaret.leibovic)

Comment 3

2 years ago
Comment on attachment 8742471 [details]
MozReview Request: Bug 1218317 - Retrieve the file size for finished downloads. r=margaret

https://reviewboard.mozilla.org/r/47215/#review44239

Nice. (Disclaimer: I didn't build this to test, but I'll trust you tested it)
Attachment #8742471 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 4

2 years ago
I did, that's how I discovered to check for download.target.exists as well, so downloads where the file has been deleted don't show up as "0 bytes".

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c26caa4d2d3e&selectedJob=19682369
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a71ec431c13
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Created attachment 8749095 [details]
Screenshot_20160505-120337.png

Size of files is displayed in "about:downloads" after restarting Firefox, but fourteen figures are still displayed after the decimal separator for file size
Tested using:
Device: Samsung Galaxy S7 Edge (Android 6.0)
Build: Firefox for Android 49.0a1 (2016-05-03)
(Assignee)

Updated

2 years ago
See Also: → bug 1270429
You need to log in before you can comment on or make changes to this bug.