Closed Bug 1218317 Opened 4 years ago Closed 4 years ago
Size of files not displayed in "about:downloads" after restarting Firefox
99.90 KB, image/png
58 bytes, text/x-review-board-request
268.01 KB, image/png
Steps to reproduce: 1. Download a file, check download manager 2. Restart Firefox, check download manager Expected result: 1. Only one figure is displayed after the decimal separator for file size 2. Size of file is correctly displayed Actual result: 1. Fourteen figures are displayed after the decimal separator for file size 2. Size of file is not displayed (unknown size) PS: The issue whit the figures after the decimal separator is not reproducing on Firefox 41.0.2
tracking-fennec: --- → ?
You should take a look in the code here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutDownloads.js
Review commit: https://reviewboard.mozilla.org/r/47215/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47215/
Attachment #8742471 - Flags: review?(margaret.leibovic)
Comment on attachment 8742471 [details] MozReview Request: Bug 1218317 - Retrieve the file size for finished downloads. r=margaret https://reviewboard.mozilla.org/r/47215/#review44239 Nice. (Disclaimer: I didn't build this to test, but I'll trust you tested it)
Attachment #8742471 - Flags: review?(margaret.leibovic) → review+
I did, that's how I discovered to check for download.target.exists as well, so downloads where the file has been deleted don't show up as "0 bytes". https://treeherder.mozilla.org/#/jobs?repo=try&revision=c26caa4d2d3e&selectedJob=19682369
Size of files is displayed in "about:downloads" after restarting Firefox, but fourteen figures are still displayed after the decimal separator for file size Tested using: Device: Samsung Galaxy S7 Edge (Android 6.0) Build: Firefox for Android 49.0a1 (2016-05-03)
You need to log in before you can comment on or make changes to this bug.