Closed Bug 1218373 Opened 4 years ago Closed 4 years ago

[mozversion] Command line interface broken by bug 1014760

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

(Keywords: regression)

Attachments

(1 file)

It appears that the command line interface for mozversion has been broken since bug 1014760 landed. The fix is simple, I'll have a patch ready shortly.
Comment on attachment 8678812 [details] [diff] [review]
Fix command line interface. v1.0

Review of attachment 8678812 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I'm somewhat surprised this broke, as mozlog.structured was supposed to redirect back to mozlog. Oh well, this should be cleaned up either way. r+ with the comment addressed.

::: testing/mozbase/mozversion/mozversion/mozversion.py
@@ +315,5 @@
>          help='host running adb')
>      fxos.add_argument(
>          '--adb-port',
>          help='port running adb')
> +    mozlog.commandline.add_logging_group(

I assume there's a "from mozlog import structured" above that also needs to be removed?
Attachment #8678812 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> I assume there's a "from mozlog import structured" above that also needs to
> be removed?

No, it was removed in bug 1014760 and probably explains exactly why this broke.

No try run as the CLI is not used by anything in tree (clearly).
Keywords: checkin-needed
Oh, I see. Sorry about that!
https://hg.mozilla.org/mozilla-central/rev/f1f6a7ae585e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.