1218373 - [mozversion] Command line interface broken by bug 1014760

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It appears that the command line interface for mozversion has been broken since bug 1014760 landed. The fix is simple, I'll have a patch ready shortly.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Fix command line interface. v1.0

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8678812 [details] [diff] [review]
Fix command line interface. v1.0

Review of attachment 8678812 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I'm somewhat surprised this broke, as mozlog.structured was supposed to redirect back to mozlog. Oh well, this should be cleaned up either way. r+ with the comment addressed.

::: testing/mozbase/mozversion/mozversion/mozversion.py
@@ +315,5 @@
>          help='host running adb')
>      fxos.add_argument(
>          '--adb-port',
>          help='port running adb')
> +    mozlog.commandline.add_logging_group(

I assume there's a "from mozlog import structured" above that also needs to be removed?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> I assume there's a "from mozlog import structured" above that also needs to
> be removed?

No, it was removed in bug 1014760 and probably explains exactly why this broke.

No try run as the CLI is not used by anything in tree (clearly).

Comment 4

[Andrew Halberstadt [:ahal]]

Oh, I see. Sorry about that!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f6a7ae585e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1f6a7ae585e