1218547 - [email] Carets for list items that have sub-views

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

In the pull request[1] for bug 1216496, we ran into an issue with the > carets shown for items, particularly in the email account settings area, where the presence of the caret indicates the user can tap on the item to go to a new view that has more detail.

There was discussion at one time with UX that they were thinking of going without the carets for RTL reasons, but I do not recall if that was just a temporary thing for 2.2 or the final official answer going forward for both RTL and LTR cases.

So pinging Juwei from UX to get the final answer, but I am not sure who the UX person is for this issue though since it is probably a broader question than just email.

With a more recent changeset for the shared buttons style[2], the forward > caret no longer exists, so if the carets are desired, then this bug can track fixing the carets, otherwise removing the code around trying to specify them.

[1] https://github.com/mozilla-b2g/gaia/pull/32697/files#r42979042
[2] https://github.com/mozilla-b2g/gaia/commit/a05b061a05fb9e2f624a66258df8ca6125089dac

Comment 1

[Augustin Trancart [:autra]]

(In reply to James Burke [:jrburke] from comment #0)
> 
> There was discussion at one time with UX that they were thinking of going
> without the carets for RTL reasons, but I do not recall if that was just a
> temporary thing for 2.2 or the final official answer going forward for both
> RTL and LTR cases.

This was a temporary thing for 2.2. FWIW the caret is back and mirrored in the settings app for example.


> With a more recent changeset for the shared buttons style[2], the forward >
> caret no longer exists, 

Oh I see. This is actually really bad. The forward-light.png shouldn't have been removed there, but renamed into right-light.png and a left-light.png image should have been added :-( We should have checked that forward-light.png wasn't used at all before removing it.

So I'm taking this, unless Jhuang says otherwise.

Comment 2

[James Burke [:jrburke]]

Clearing the need to bother Juwei about this, since :autra has a handle from it from working with other apps that have the same caret and rtl/ltr needs.

Comment 3

[Juwei Huang[:juwei]]

Hi James,
I just checked with Harly, the latest RTL spec is here (p.13): https://mozilla.box.com/s/bcm3s5i2v6js5uk0ws3tsywse8bgncgo
On p.13, both RTL & LTR have > carets.

As for the future planing of RTL, please contact Harly/Rob for further information :)

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1218547-email_caret > mozilla-b2g:master

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8680763 [details] [review]
[gaia] Phoxygen:bug1218547-email_caret > mozilla-b2g:master

Hi James, please R?

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8680763 [details] [review]
[gaia] Phoxygen:bug1218547-email_caret > mozilla-b2g:master

Looks great, thank you!

Comment 7

[Augustin Trancart [:autra]]

NI myself to land this when tests are green.

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/296715e1665ae6cf28f16047971cae225b8c5397

Comment 9

[Augustin Trancart [:autra]]

Comment on attachment 8680763 [details] [review]
[gaia] Phoxygen:bug1218547-email_caret > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1207259
[User impact] if declined: Image missing in email in settings view
[Testing completed]: on Flame master
[Risk to taking this patch] (and alternatives if risky): Low, it partially revert patch for bug 1207259 and add images for RTL view.
[String changes made]: None

Comment 10

[Augustin Trancart [:autra]]

Comment on attachment 8680763 [details] [review]
[gaia] Phoxygen:bug1218547-email_caret > mozilla-b2g:master

Already in 2.5.