1218560 - Fix heap tree view with allocation stack breakdown

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Fix heap tree view with allocation stack breakdown

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8679088 [details] [diff] [review]
Fix heap tree view with allocation stack breakdown

Review of attachment 8679088 [details] [diff] [review]:
-----------------------------------------------------------------

nit: more clear commit message

::: devtools/client/memory/components/tree-item.js
@@ +34,5 @@
> +      ? this.savedFrameToLabel(name)
> +      : String(name);
> +  },
> +
> +  savedFrameToLabel(frame) {

docs

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/15acea2927e2

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/3af8b8e56340 since I didn't know whether it was this or bug 1217500 leaking like https://treeherder.mozilla.org/logviewer.html#?job_id=5354136&repo=fx-team

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Figuring out which patch triggered the leaks.

Try push with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67d5e5232c76

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Try push with this patch and without the tests https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f95f8817c57

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0387c496dd41

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Part 2: Add an integration test for allocation stack breakdowns

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push for part 2: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3aae4c3ef701

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2e2f56672850

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0387c496dd41

Comment 12

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=8edcaa544e24 since one of this changes caused test failures on windows and OS X like https://treeherder.mozilla.org/logviewer.html#?job_id=5401492&repo=fx-team

Comment 13

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/205846a3aef5

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3e62a45284be

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e62a45284be