Closed Bug 1218560 Opened 4 years ago Closed 4 years ago

Fix heap tree view with allocation stack breakdown

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8679088 [details] [diff] [review]
Fix heap tree view with allocation stack breakdown

Review of attachment 8679088 [details] [diff] [review]:
-----------------------------------------------------------------

nit: more clear commit message

::: devtools/client/memory/components/tree-item.js
@@ +34,5 @@
> +      ? this.savedFrameToLabel(name)
> +      : String(name);
> +  },
> +
> +  savedFrameToLabel(frame) {

docs
Attachment #8679088 - Flags: review?(jsantell) → review+
Figuring out which patch triggered the leaks.

Try push with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67d5e5232c76
Depends on: 1218679
Depends on: 1219066
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=8edcaa544e24 since one of this changes caused test failures on windows and OS X like https://treeherder.mozilla.org/logviewer.html#?job_id=5401492&repo=fx-team
https://hg.mozilla.org/mozilla-central/rev/3e62a45284be
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.