Closed Bug 1218666 Opened 7 years ago Closed 7 years ago
Play icon will hide when get a notification
Play icon will hide when get a notification. STR: 1. Play a music. 2. Go to Settings app, set volume for "Ringtones & Notifications" in "Sound" panel. Actual result: Play icon is hidden. Expected result: Play icon is still showed.
Updated patch and added tests: https://github.com/evanxd/gaia/commit/fa7aa16b3cce294d5c3d8a964184d8eb1cf06ccb
Comment on attachment 8679247 [details] [review] [gaia] evanxd:bug-1218666 > mozilla-b2g:master Hi Alastor, Could you review the patch? Thanks.
Attachment #8679247 - Flags: review?(alwu)
Comment on attachment 8679247 [details] [review] [gaia] evanxd:bug-1218666 > mozilla-b2g:master LGTM, only have one suggestion in the PR.
Attachment #8679247 - Flags: review?(alwu) → review+
Alastor, thanks for the review.
Updated patch for the comments: https://github.com/evanxd/gaia/commit/51030ac88c47ea3bb1a9efff93212416f0d26ced Also need to fix failed unit test. Continue to fix after I figure out the Bug 1213666.
Fixed the test. Once treeherder is good, let's land the code. : https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f9109be19ed1fd9837f6dbb8752cf7ac242a950d
[Blocking Requested - why for this release]: The play icon will be hidden when Music app is still playing.
blocking-b2g: --- → 2.5?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.