Closed Bug 1218666 Opened 7 years ago Closed 7 years ago

Play icon will hide when get a notification

Categories

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Audio Mgmt
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5?)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5?

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

Attachments

(1 file)

[gaia] evanxd:bug-1218666 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
alwu
: review+
Details | Review 
Play icon will hide when get a notification.

STR:
1. Play a music.
2. Go to Settings app, set volume for "Ringtones & Notifications" in "Sound" panel.

Actual result:
Play icon is hidden.

Expected result:
Play icon is still showed.
Blocks: 1218691
Blocks: 1218690
Blocks: 1096163
Comment on attachment 8679247 [details] [review]
[gaia] evanxd:bug-1218666 > mozilla-b2g:master

Hi Alastor,

Could you review the patch?

Thanks.
Attachment #8679247 - Flags: review?(alwu)
Comment on attachment 8679247 [details] [review]
[gaia] evanxd:bug-1218666 > mozilla-b2g:master

LGTM, only have one suggestion in the PR.
Attachment #8679247 - Flags: review?(alwu) → review+
Alastor, thanks for the review.
Updated patch for the comments: https://github.com/evanxd/gaia/commit/51030ac88c47ea3bb1a9efff93212416f0d26ced

Also need to fix failed unit test. Continue to fix after I figure out the Bug 1213666.
Fixed the test. Once treeherder[1] is good, let's land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f9109be19ed1fd9837f6dbb8752cf7ac242a950d
[Blocking Requested - why for this release]: The play icon will be hidden when Music app is still playing.
blocking-b2g: --- → 2.5?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.