1218724 - Refine error UI on TV

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P3)

Description

[Michiel de Jong [:michielbdejong]]

When the Syncto server responds with a 401, a full-screen alert pops up with the text:

         Unknown error
           undefined


This looks a bit user-unfriendly. 401s from Syncto should never occur in production, but if other responses (like 502 Service Unavailable) use this same alert, then we could polish this view, maybe changing the two lines of text to look a bit more user-friendly.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1218724.unknown.error > mozilla-b2g:master

Comment 2

[yifan [:yifan][:yliao]]

Comment on attachment 8680062 [details] [review]
[gaia] ferjm:bug1218724.unknown.error > mozilla-b2g:master

Thanks!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/406cc1240e9592f9a30b898d87223974c0cb3519

Comment 4

[Francesco Lodolo [:flod]]

Note to dev and reviewer for future bugs: do not change strings without using new IDs.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Changing string IDs is the only way for localizers to know about a string change.

I'm not going to ask you to fix or back-out this change (normally I would), because the previous version of the strings was not exposed yet by pure chance.

As a general rule, if you're changing a string in gaia master, change the ID unless it's just fixing a typo. If you have doubts, please ask.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Thank you Francesco. None of these strings made it into production yet as they are being added along with the Sync feature during the 2.5 dev process, so I figured that no string ID change was needed.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> Thank you Francesco. None of these strings made it into production yet as
> they are being added along with the Sync feature during the 2.5 dev process,
> so I figured that no string ID change was needed.

For clarity: the discriminant is not if they're used in production, but if they landed in the repository on GitHub.

Once landed, they're exposed to localization and we won't know if someone translated the first version and never updated them. So, if a change is important, we need new string IDs.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Oh, good to know. Thanks for the explanation Francesco.