Port Bug 1211765 Kill --with-libxul-sdk for good to c-c

RESOLVED FIXED in Thunderbird 45.0

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
Thunderbird 45.0

Thunderbird Tracking Flags

(thunderbird45 fixed, seamonkey2.42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8679758 [details] [diff] [review]
Port changes to c-c

+++ This bug was initially created as a clone of Bug #1211765 +++

Bug 1038639 only really removed --with-system-libxul, made --with-libxul-sdk error out, but left a bunch of conditionals for the --with-libxul-sdk case. Obviously, no one has been using this for over 8 months, since bug 870366 broke the build when LIBXUL_SDK is set by setting an unsupported variable in moz.build in the corresponding branch. Let's just remove it all. If we ever restore some similar functionality (which is actually something I have in mind), it will be completely different anyways.
Attachment #8679758 - Flags: review?(bugspam.Callek)
Attachment #8679758 - Flags: review?(aleth)
Attachment #8679758 - Flags: review?(Pidgeot18)

Comment 1

3 years ago
Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

(fwd)
Attachment #8679758 - Flags: review?(aleth) → review?(florian)
Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8679758 - Flags: review?(florian) → review+
Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason, I thought there was more LIBXUL_SDK floating around. I was probably mixing it up with --enable-incomplete-external-linkage.
Attachment #8679758 - Flags: review?(Pidgeot18) → review+

Comment 4

3 years ago
https://hg.mozilla.org/comm-central/rev/7a674f9ee355

Sorry, I overlooked this was still missing a suite/ review. Please back out if appropriate.
(Assignee)

Comment 5

3 years ago
Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Enough eyes have been across this.
Attachment #8679758 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
status-firefox44: affected → ---
status-seamonkey2.42: --- → fixed
status-thunderbird45: --- → fixed
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.