1219080 - Port Bug 1211765 Kill --with-libxul-sdk for good to c-c

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ian Neal]

Attachment: Port changes to c-c

+++ This bug was initially created as a clone of Bug #1211765 +++

Bug 1038639 only really removed --with-system-libxul, made --with-libxul-sdk error out, but left a bunch of conditionals for the --with-libxul-sdk case. Obviously, no one has been using this for over 8 months, since bug 870366 broke the build when LIBXUL_SDK is set by setting an unsupported variable in moz.build in the corresponding branch. Let's just remove it all. If we ever restore some similar functionality (which is actually something I have in mind), it will be completely different anyways.

Comment 1

[aleth [:aleth]]

Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

(fwd)

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Review of attachment 8679758 [details] [diff] [review]:
-----------------------------------------------------------------

For some reason, I thought there was more LIBXUL_SDK floating around. I was probably mixing it up with --enable-incomplete-external-linkage.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/7a674f9ee355

Sorry, I overlooked this was still missing a suite/ review. Please back out if appropriate.

Comment 5

[Ian Neal]

Comment on attachment 8679758 [details] [diff] [review]
Port changes to c-c

Enough eyes have been across this.