Closed Bug 1211765 Opened 8 years ago Closed 8 years ago

Kill --with-libxul-sdk for good

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Remove remnants from --with-libxul-sdk
42.73 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
Bug 1038639 only really removed --with-system-libxul, made --with-libxul-sdk error out, but left a bunch of conditionals for the --with-libxul-sdk case. Obviously, no one has been using this for over 8 months, since bug 870366 broke the build when LIBXUL_SDK is set by setting an unsupported variable in moz.build in the corresponding branch. Let's just remove it all. If we ever restore some similar functionality (which is actually something I have in mind), it will be completely different anyways.
The configure option has explicitly thrown an error for more than a year now,
and it happens that the remaining way to still forcefully use it has been
broken for more than 8 months.
Assignee: nobody → mh+mozilla
Attachment #8670096 - Flags: review?(benjamin)
Attachment #8670096 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/0dba8a2a8679
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
No. Feel free to file a followup bug.
Flags: needinfo?(mh+mozilla)
Blocks: 1219080
Blocks: 1219081
https://hg.mozilla.org/comm-central/rev/7a674f9ee35503b88660df41e4616967b72ad765
Port Bug 1211765 Kill --with-libxul-sdk for good to c-c r=jcranmer,callek,aleth a=aleth CLOSED TREE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.