Kill --with-libxul-sdk for good

RESOLVED FIXED in Firefox 44

Status

RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla44
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1038639 only really removed --with-system-libxul, made --with-libxul-sdk error out, but left a bunch of conditionals for the --with-libxul-sdk case. Obviously, no one has been using this for over 8 months, since bug 870366 broke the build when LIBXUL_SDK is set by setting an unsupported variable in moz.build in the corresponding branch. Let's just remove it all. If we ever restore some similar functionality (which is actually something I have in mind), it will be completely different anyways.
(Assignee)

Comment 1

3 years ago
Created attachment 8670096 [details] [diff] [review]
Remove remnants from --with-libxul-sdk

The configure option has explicitly thrown an error for more than a year now,
and it happens that the remaining way to still forcefully use it has been
broken for more than 8 months.
Assignee: nobody → mh+mozilla
Attachment #8670096 - Flags: review?(benjamin)

Updated

3 years ago
Attachment #8670096 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/0dba8a2a8679
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

Comment 4

3 years ago
Is http://mxr.mozilla.org/mozilla-central/source/config/makefiles/xpidl/Makefile.in#39 still needed?
Flags: needinfo?(mh+mozilla)
(Assignee)

Comment 5

3 years ago
No. Feel free to file a followup bug.
Flags: needinfo?(mh+mozilla)

Updated

3 years ago
Blocks: 1219080

Updated

3 years ago
Blocks: 1219081

Comment 6

3 years ago
https://hg.mozilla.org/comm-central/rev/7a674f9ee35503b88660df41e4616967b72ad765
Port Bug 1211765 Kill --with-libxul-sdk for good to c-c r=jcranmer,callek,aleth a=aleth CLOSED TREE

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.