1219245 - [TV Data Sync] 'Forgot your password' link shows activity chooser menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: [TV]FirefoxAccount_v0.5.pdf

============== Gaia Information ==============
commit ed9f29f7da11370b7c9c4a9cf3d11139537539df
Merge: 70faabf 5df0f5a
Author: tamarahills <[e-mail]>
Date:   Tue Oct 27 21:58:46 2015 -0400

Missing Hyperlinks:
 1. Terms of Service (Figure 2-3 and Figure 4-2)
 2. Privacy Notice (Figure 2-3 and Figure 4-2)
 3. Forgot your password? (Figure2-7)

Reference:
 - [TV]FirefoxAccount_v0.5.pdf

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Actually, the 'Forgot your password?' link on the FxA flow is broken. It shows the activity chooser menu.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1219245.forgotpassword.fxa.tv > mozilla-b2g:master

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8681328 [details] [review]
[gaia] ferjm:bug1219245.forgotpassword.fxa.tv > mozilla-b2g:master

This fixes the url 'view' activity in general as well.

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8681328 [details] [review]
[gaia] ferjm:bug1219245.forgotpassword.fxa.tv > mozilla-b2g:master

Thank you! Just one thing that to align to the behavior when a user clicks a webpage shortcut at the smart-home, we open a new tab if the current browser tab is not empty.

Comment 6

[yifan [:yifan][:yliao]]

Please require approval for v2.5 after the update, thank you!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/79bd73d3f806e24010f883828f76e3289c0ecda6

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8681328 [details] [review]
[gaia] ferjm:bug1219245.forgotpassword.fxa.tv > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Firefox Sync
[User impact] if declined: An ugly activity choose menu that has no proper layout for the TV will be shown to the user with two options: System and Browser. Clicking any of the options won't work and an error about an unverified account totally unrelated to the real problem will be shown.
[Testing completed]: Local tests.
[Risk to taking this patch] (and alternatives if risky): Ugly UX.
[String changes made]: None

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

reverted for causing a Gu failure:

TEST-UNEXPECTED-FAIL | null | [browser-test/unit/sync/settings_test.js] Sync settings > Errored should ignore ERROR_DIALOG_CLOSED_BY_USER error
ReferenceError: Settings is not defined 

https://github.com/mozilla-b2g/gaia/commit/496ab67c6220589c950fc1a96a306382da56d523

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1219245.forgotpassword.fxa.tv > mozilla-b2g:master

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/ea37373cacce9f4f928eda2e15bb03e0b0e30454