1219259 - [TV Data Sync] There should be a pop-up window if a user signs in successfully

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: [TV]FirefoxAccount_v0.5

============== Gaia Information ==============
commit ed9f29f7da11370b7c9c4a9cf3d11139537539df
Merge: 70faabf 5df0f5a
Author: tamarahills <[e-mail]>
Date:   Tue Oct 27 21:58:46 2015 -0400

STR:
 1. Launch Browser
 2. Sign in with Firefox account and password

Expected Result:
 - There is a window that shows "Sync enabled. Firefox will begin syncing bookmarks momentarily. You can choose what to sync in browser settings."
 - User can press OK/Enter  

Actual Result:
 - No pop-up window

Reference: [TV]FirefoxAccount_v0.5, page 7

Comment 1

[Cynthia Tang [:cynthiatang]]

Hi Tori,
The new string is "Success! Your Firefox Account is ready to go! In the future, you can access and manage your account from Settings.", right?

Comment 2

[Tori Chen [:tori]]

Yes, that's right!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

When the user signs in we:

1. Open the settings panel.
2. Within the settings panel, we disable the 'Sync Now' button and show the 'Syncing...' label inside it

I think showing this pop up is not needed as we are already providing to the user enough feedback about Sync being enabled.

We could avoid showing the settings panel and show this pop-up instead. Or leave it the way it is now.

What do you think Tori?

Comment 4

[Tori Chen [:tori]]

I think pop-up is more obvious than the "syncing" label, however, we also want to keep the process simple. So I have another idea - We show the pop-up, but when users press OK, just go back to previous browsing and sync in background. We can show a TV native toast when sync is finished.

Comment 5

[Tori Chen [:tori]]

What's you thought Fernando?

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Do you mean that we should *only* show the pop-up and *not* automatically show the settings panel with the "syncing" label? That works for me.

Also, should this be a fullscreen popup or would a non invasive toast work as well? (I'd prefer the toast option).

I would also prefer to avoid showing the native toast when the synchronization is done, cause we have automatic synchronizations and that can happen at any time in the background. Showing a toast for every sync request completed might be too noisy.

Comment 7

[Tori Chen [:tori]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #6)
> Do you mean that we should *only* show the pop-up and *not* automatically
> show the settings panel with the "syncing" label? That works for me.

Yes.

> Also, should this be a fullscreen popup or would a non invasive toast work
> as well? (I'd prefer the toast option).

I'd prefer the popup since there are some info on the popup we want to tell users :)

> I would also prefer to avoid showing the native toast when the
> synchronization is done, cause we have automatic synchronizations and that
> can happen at any time in the background. Showing a toast for every sync
> request completed might be too noisy.

Agreed. Can we show the sync-finished toast only for first time after they sign in? I don't have a strong opinion on either way works for me.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1219259.tv.sync.enabled.popup > mozilla-b2g:master

Comment 9

[yifan [:yifan][:yliao]]

Comment on attachment 8690449 [details] [review]
[gaia] ferjm:bug1219259.tv.sync.enabled.popup > mozilla-b2g:master

Thanks! LGTM.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/1722c2f3e92b3853fe57189978af837d63bbd9a9

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8690449 [details] [review]
[gaia] ferjm:bug1219259.tv.sync.enabled.popup > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108 
[User impact] if declined: No pop-up dialog after user sign-in
[Testing completed]: Tested on B2G desktop
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: yes

Comment 12

[Josh Cheng [:josh]]

Comment on attachment 8690449 [details] [review]
[gaia] ferjm:bug1219259.tv.sync.enabled.popup > mozilla-b2g:master

Approve for TV 2.5

Comment 13

[Carsten Book [:Tomcat]]

has problems to apply:

Already on 'v2.5'
Your branch is up-to-date with 'origin/v2.5'.
Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 5e396a7382013b12b2472f74e03cfb651779ea16
error: could not apply 5e396a7... Bug 1219259 - [TV Data Sync] There should be a pop-up window if a user signs in successfully. r=yifan
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Comment 14

[Delphine Lebédel [:delphine - Use needinfo]]

Removing late-l10n keyword here as this is in tv_apps folder (so does not affect our l10n repos).

Comment 15

[Cynthia Tang [:cynthiatang]]

Hi Josh,
Could you find someone to fix this issue in v2.5? Thank you

Comment 16

[Cynthia Tang [:cynthiatang]]

Verified on

Branch Master
commit ff662257263e9d71f8202d9d61a1b2035944e346
Merge: af7fe55 ae5cbee
Author: Johan Lorenzo <[e-mail]>
Date:   Fri Dec 4 12:26:37 2015 +0100

Comment 17

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Carsten Book [:Tomcat] from comment #13)
> has problems to apply:
> 
> Already on 'v2.5'
> Your branch is up-to-date with 'origin/v2.5'.
> Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick
> 5e396a7382013b12b2472f74e03cfb651779ea16
> error: could not apply 5e396a7... Bug 1219259 - [TV Data Sync] There should
> be a pop-up window if a user signs in successfully. r=yifan
> hint: after resolving the conflicts, mark the corrected paths
> hint: with 'git add <paths>' or 'git rm <paths>'
> hint: and commit the result with 'git commit'

I didn't get this conflicts

https://github.com/mozilla-b2g/gaia/commit/2eb55a6193b711b4acb5944be3ba8fea138506c8

Comment 18

[Josh Cheng [:josh]]

Hi tomcat,
Can you check again? Thanks.

Comment 19

[Carsten Book [:Tomcat]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #17)
> (In reply to Carsten Book [:Tomcat] from comment #13)
> > has problems to apply:
> > 
> > Already on 'v2.5'
> > Your branch is up-to-date with 'origin/v2.5'.
> > Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick
> > 5e396a7382013b12b2472f74e03cfb651779ea16
> > error: could not apply 5e396a7... Bug 1219259 - [TV Data Sync] There should
> > be a pop-up window if a user signs in successfully. r=yifan
> > hint: after resolving the conflicts, mark the corrected paths
> > hint: with 'git add <paths>' or 'git rm <paths>'
> > hint: and commit the result with 'git commit'
> 
> I didn't get this conflicts
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 2eb55a6193b711b4acb5944be3ba8fea138506c8

seems this is now on 2.5 https://hg.mozilla.org/integration/gaia-2_5/rev/596cfd8f22e0

Comment 20

[Josh Cheng [:josh]]

Hi Cynthia,
Could you check again on 2.5 again? The patch should be there. ;)

Comment 21

[Cynthia Tang [:cynthiatang]]

Verified on:

Branch v2.5
Commit 062e0fa48c1b5d5156f6911a5a4519128fac3231
Author: danhuang1202 <[e-mail]>
Date:   Fri Nov 27 16:53:24 2015 +0800