1219279 - Running without --restart option broken, because of wrong code in touch_home_button

Status: RESOLVED FIXED

Description

[Martijn Wargers (dead)]

I caused this in bug 1217870.
This caused the Sunspider test on https://arewefastyet.com/#machine=26 to fail:
https://github.com/nbp/gaia-ui-tests/blob/bench/gaiatest/tests/browser/benchmarks/test_bench_sunspider.py#L19

Comment 1

[Autolander]

Created attachment 8680071 [details] [review]
[gaia] mwargers:1219279 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

The fix in running_apps was also needed for me to get test_bench_sunspider.py working (and there was another unrelated issue which I saw, but I'm working already on that in another bug).

Comment 3

[Martijn Wargers (dead)]

I saw this also failing in test_browser_clear_browsing_history.py, so we would have caused this failure in our own tests, too.

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8680071 [details] [review]
[gaia] mwargers:1219279 > mozilla-b2g:master

If it runs, it looks good to me. let me know if you want me to test it out locally.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8680071 [details] [review]
[gaia] mwargers:1219279 > mozilla-b2g:master

Looks good to me. Sorry I missed the lambda during the review.

Comment 6

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/b8347d5cc4815da673f38fce84c7c20728b71466