1217870 - test_homescreen_status_bar_icons_visibility.py doesn't run anymore

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

This test was very specific to the old homescreen. I checked if the rocketbar was reduced when you scroll down the homescreen.

I'm not sure if we should delete or update it. What do you guys think?

Comment 1

[No-Jun Park [:njpark]]

Right, and currently the search bar does not get reduced.  Although there are many new tests we can write about the new homescreen, I don't they they actually fall under the scope of this test.  I suggest we remove this test.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1217870 > mozilla-b2g:master

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

Sorry, I couldn't resist fixing the test, but I'm also fine with deleting the test.

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

Ah, so you're taking the screenshots before/after and comparing them.  I have two concerns:

1. the test must complete within a minute, (it's a low risk since the action is pretty quick)
2. if there is any kind of change in radio/wifi reception, this will affect the test result since it'll change the status icons.
3. If there is a notification happening, (i.e. marketplace then that'll also affect the test.

We could add the scroll action into the test_drag_drop.py in imagecompare folder and it might accomplish the same thing.

Comment 5

[Martijn Wargers (dead)]

I've retried 10 times and they all passed. I'm pretty sure the tests completes within one minute.
There should be no notifications happening with the test.
I could put the device in flight mode, that should mitigate the change in radio/wifi icon problem.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

That's a good start. Thanks to you changes, I am convinced we should keep it.

Like No-Jun said, the screenshot is likely not the best option. I proposed an alternative in the PR.

Comment 7

[Martijn Wargers (dead)]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

I think I addressed all the review comments from Johan here.
The removal of status_bar.maximized/status_bar.minimized makes this a much larger pull request.

I'm wondering why status_bar.maximized/status_bar.minimized actually can be removed. Was that changed?

Comment 8

[Martijn Wargers (dead)]

Btw, I couldn't find usage of .maximized/.minized in other consumers of Gaia UI test:
https://github.com/Mozilla-TWQA/MTBF-Driver/search?utf8=%E2%9C%93&q=minimized&type=Code
https://github.com/mozilla-raptor/raptor-cli/search?utf8=%E2%9C%93&q=minimized&type=Code
https://github.com/JonHylands/power-tests/search?utf8=%E2%9C%93&q=minimized&type=Code

Comment 9

[No-Jun Park [:njpark]]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

Since you addressed most of the concerns, the patch looks good and we should run this to see what happens in the long run.

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678468 [details] [review]
[gaia] mwargers:1217870 > mozilla-b2g:master

The test looks great! I wish we could have more tests that are 8-line-long like this one. Thanks!

Comment 11

[Martijn Wargers (dead)]

Addressed the nits, squashed the commits and then merged: https://github.com/mozilla-b2g/gaia/commit/a26eadc5e1133d5112b6cbc10badbb7670a1090f