1219416 - Display "Search" title when opening search preferences with the magnifying glass

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Christian Schmitz (:tynn)]

When opening search preferences with the magnifying glass, the title displayed shows the name of the build. Instead it should display "Search".

Comment 1

[Christian Schmitz (:tynn)]

Attachment: bug1219416.patch

I couldn't verify it for preHC, but updateTitleForPrefsResource() should take care of it.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8680229 [details] [diff] [review]
bug1219416.patch

Review of attachment 8680229 [details] [diff] [review]:
-----------------------------------------------------------------

I was just working in this code, but I still find it confusing! This looks like the right thing to do. I also don't have a preHC device to test, so I can flag our QA team to help verify this once it lands.

Comment 3

[Christian Schmitz (:tynn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d698b572556

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Tracking 44 to match the bug this code landed in.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/76627e2cb506

Comment 6

[:Margaret Leibovic]

Comment on attachment 8680229 [details] [diff] [review]
bug1219416.patch

Merge came early, so we need to uplift...

Approval Request Comment
[Feature/regressing bug #]: bug 1172083

[User impact if declined]: The search settings page will have the wrong title when opened from the quick search bar.

[Describe test coverage new/current, TreeHerder]: No automated test, just landed on fx-team.

[Risks and why]: Low-risk, small change to how we display titles on settings pages.

[String/UUID change made/needed]: none

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76627e2cb506

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8680229 [details] [diff] [review]
bug1219416.patch

Fix looks simple enough and has been on Nightly for a few days. Let's uplift to Aurora44.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/76627e2cb506

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1cfd7b285723

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1cfd7b285723

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Tapping the magnifying glass from the quick search bar opens the "Search" sub-menu from settings. "Search" is displayed as title.
Verified as fixed using:
Device: Xiaomi Mi i4 (Android 5.0.2)
Build: Firefox for Android 45.0a1 (2015-11-11)

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Tapping the magnifying glass from the quick search bar opens the "Search" sub-menu from settings. "Search" is displayed as title.
Verified as fixed using:
Device: Moto X (Android 4.4)
Build: Firefox for Android 44.0a2 (2015-11-23)