Closed Bug 1219474 Opened 4 years ago Closed 4 years ago

Replace PRLogModuleInfo usage with LazyLogModule in imagelib

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: erahm, Assigned: sajitk)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1219470 +++

This covers replacing PRLogModuleInfo w/ LazyLogModule in the 'image/' directory.

Current usage:
> ./image/decoders/nsBMPDecoder.cpp:170:    sBMPLog = PR_NewLogModule("BMPDecoder");
> ./image/decoders/nsJPEGDecoder.cpp:44:    sJPEGLog = PR_NewLogModule("JPEGDecoder");
> ./image/decoders/nsJPEGDecoder.cpp:54:    sJPEGDecoderAccountingLog = PR_NewLogModule("JPEGDecoderAccounting");
> ./image/decoders/nsPNGDecoder.cpp:32:    sPNGLog = PR_NewLogModule("PNGDecoder");
> ./image/decoders/nsPNGDecoder.cpp:42:    sPNGDecoderAccountingLog = PR_NewLogModule("PNGDecoderAccounting");
> ./image/encoders/png/nsPNGEncoder.cpp:20:    sPNGEncoderLog = PR_NewLogModule("PNGEncoder");
> ./image/imgRequest.cpp:50:    sImgLog = PR_NewLogModule("imgRequest");
Whiteboard: [gfx-noted]
Assignee: nobody → sajitk
Attachment #8684235 - Flags: review?(seth)
Comment on attachment 8684235 [details] [diff] [review]
Replace PRLogModuleInfo w/ LazyLogModule in the 'image/'

Review of attachment 8684235 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! This can land as-is, but it'd be better with the change below:

::: image/imgRequest.cpp
@@ +46,1 @@
>  GetImgLog()

Can we just get rid of GetImgLog()? We don't really need it in a LazyLogModule world, do we?
Attachment #8684235 - Flags: review?(seth) → review+
Attached patch 1219474.patchSplinter Review
Attachment #8684235 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/48011a9ee633
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.