1219474 - Replace PRLogModuleInfo usage with LazyLogModule in imagelib

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #1219470 +++

This covers replacing PRLogModuleInfo w/ LazyLogModule in the 'image/' directory.

Current usage:
> ./image/decoders/nsBMPDecoder.cpp:170:    sBMPLog = PR_NewLogModule("BMPDecoder");
> ./image/decoders/nsJPEGDecoder.cpp:44:    sJPEGLog = PR_NewLogModule("JPEGDecoder");
> ./image/decoders/nsJPEGDecoder.cpp:54:    sJPEGDecoderAccountingLog = PR_NewLogModule("JPEGDecoderAccounting");
> ./image/decoders/nsPNGDecoder.cpp:32:    sPNGLog = PR_NewLogModule("PNGDecoder");
> ./image/decoders/nsPNGDecoder.cpp:42:    sPNGDecoderAccountingLog = PR_NewLogModule("PNGDecoderAccounting");
> ./image/encoders/png/nsPNGEncoder.cpp:20:    sPNGEncoderLog = PR_NewLogModule("PNGEncoder");
> ./image/imgRequest.cpp:50:    sImgLog = PR_NewLogModule("imgRequest");

Comment 1

[sajitk]

Attachment: Replace PRLogModuleInfo w/ LazyLogModule in the 'image/'

Comment 2

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8684235 [details] [diff] [review]
Replace PRLogModuleInfo w/ LazyLogModule in the 'image/'

Review of attachment 8684235 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! This can land as-is, but it'd be better with the change below:

::: image/imgRequest.cpp
@@ +46,1 @@
>  GetImgLog()

Can we just get rid of GetImgLog()? We don't really need it in a LazyLogModule world, do we?

Comment 3

[sajitk]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=999ac4b4ec36

Comment 4

[sajitk]

Attachment: 1219474.patch

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48011a9ee633

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48011a9ee633