1219461 - Replace PRLogModuleInfo usage with LazyLogModule

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #1174785 +++

In order to fix various TSan issues and advance the goal of switching away from NSPR logging we need to replace the direct usage of PRLogModuleInfo.

I'll file blocking bugs for doing this within various components.

The following patterns will need to be handled, making this a little tricky to automate. As of filing this there are about 260 instances to replace.

File Scoped Global
==================
> PRLogModuleInfo* (s|g|k)FooLogger;
> ....
> void Foo::Foo()
>   if (!sFooLogger) fooLogger = PR_NewLog("FooLogger");

This would become:
> LazyLogModule (s|g|k)FooLogger("FooLogger");

File Scoped Getter Function
===========================
> PR_LogModuleInfo* GetFooLogger() {
>  static (s|g)?(F|f)ooLogger = nullptr;
>  if (!fooLogger) fooLogger = PR_NewLog("FooLogger");
>  return fooLogger;
> }
> ...
> void blah() { MOZ_LOG(GetFooLogger(), ...); }

This would become:
> LazyLogModule sFooLogger("FooLogger");
> ...
> void blah() { MOZ_LOG(sFooLogger, ...); }

Note: all |GetFooLogger| calls would need to replaced

External variations
===================
Some areas declare an |extern PRLogModuleInfo* sFooLogger|, these would need to be updated as well.

Comment 1

[Eric Rahm [:erahm]]

All blockers are complete.