Closed
Bug 1219630
Opened 9 years ago
Closed 9 years ago
Implement *test_browser_search.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(feature-b2g:2.6+)
People
(Reporter: whsu, Assigned: apastor)
References
Details
(Whiteboard: [gip-to-gij][systemsfe])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Browser
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.6+
|
Assignee | |
Comment 1•9 years ago
|
||
The file doesnt seem to exist. William, could you point to the correct one or close this bug? Thanks!
Flags: needinfo?(whsu)
|
|
Reporter | |
Comment 2•9 years ago
|
||
@ Alberto, sorry for the late response. @ Johan, can we close this bug since it had been removed from master branch? Thank you.
Flags: needinfo?(whsu) → needinfo?(jlorenzo)
|
||
Comment 3•9 years ago
|
||
Sorry about the link. Bug 1141315 deleted it. There, it has been decided [1] was a fair replacement. After taking a closer look to that test, I'm not sure the replacement is equivalent. These 2 lines[2] makes sure a regular string redirects to a URL after tapping Enter. However, I'm not sure we verify the URL contains the query given, like [3]. Alberto, are you aware of a test that makes sure we include the query in search URLs? [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/search/test/marionette/search_rocketbar_test.js [2] https://github.com/mozilla-b2g/gaia/blob/master/apps/search/test/marionette/search_rocketbar_test.js#L103-L104 [3] For example a Google request is like: https://www.google.com/?q=MY_ROCKETBAR_ENTERED_TEXT
Flags: needinfo?(jlorenzo) → needinfo?(apastor)
|
|
Assignee | |
Comment 4•9 years ago
|
||
I don't think we are verifying that in any test. I'll add that check to the existing ones. THanks!
Assignee: nobody → apastor
Flags: needinfo?(apastor)
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: --- → 2.6 S3 - 12/18
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [gip-to-gij] → [gip-to-gij][systemsfe]
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [gip-to-gij][systemsfe] → [gip-to-gij],[systemsfe]
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [gip-to-gij],[systemsfe] → [gip-to-gij][systemsfe]
|
|
Assignee | |
Updated•9 years ago
|
Component: Gaia::Browser → Gaia::System
|
|
Assignee | |
Updated•9 years ago
|
Component: Gaia::System → Gaia::Browser
|
||
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8698436 [details] [review] [gaia] albertopq:1219630-test-browser-search > mozilla-b2g:master Johan, could you take a look? Thanks!
Attachment #8698436 -
Flags: review?(jlorenzo)
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8698436 [details] [review] [gaia] albertopq:1219630-test-browser-search > mozilla-b2g:master Nice test! I left a couple of polish comments in there. But the patch as is looks already fine. Thanks!
Attachment #8698436 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/b50b0faa587bdb96cccd704df0257b6459ddb19d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•