Closed
Bug 1219640
Opened 9 years ago
Closed 9 years ago
Implement *test_default_contact_image.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
| feature-b2g | 2.6+ |
People
(Reporter: whsu, Assigned: arcturus)
References
Details
(Whiteboard: [gip-to-gij])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Contacts
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.6+
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → francisco
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8694156 -
Flags: review?(jlorenzo)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8694156 [details] [review] [gaia] arcturus:bug-1219640 > mozilla-b2g:master This new test of 2 lines is great! I wish more tests could be as short as this one :) I think we can improve firstContactHasDefaultImage() to use Marionette's APIs and check the if the letter is present in the DOM. I left more details in the PR. Tell me what you think.
Attachment #8694156 -
Flags: review?(jlorenzo)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8694156 [details] [review] [gaia] arcturus:bug-1219640 > mozilla-b2g:master Added suggestions, both using marionette api and checking the letter.
Attachment #8694156 -
Flags: review?(jlorenzo)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8694156 [details] [review] [gaia] arcturus:bug-1219640 > mozilla-b2g:master Looks good to me, based on the current design of the Gij tests in Contacts.
Attachment #8694156 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/2fe23c55b2c00e106242cac6a61c6bdb650a7666
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•