1230099 - Delete tests already ported to Gij - round #2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

These tests don't require to be tested on device, they just check the integration in either gaia, or gecko and gaia. They have already been ported to Gij.

See dependent bugs to get the list.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Let's wait for some more tests ported, just like in bug 1228972.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1230099 > mozilla-b2g:master

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8699507 [details] [review]
[gaia] JohanLorenzo:bug-1230099 > mozilla-b2g:master

See the dependent bugs to get the list of tests which should be removed by this PR.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8699507 [details] [review]
[gaia] JohanLorenzo:bug-1230099 > mozilla-b2g:master

Looks fine by me.

Comment 5

[No-Jun Park [:njpark]]

Comment on attachment 8699507 [details] [review]
[gaia] JohanLorenzo:bug-1230099 > mozilla-b2g:master

Agree those tests can be done on Gij.  
Wonder we discussed this before - but can we just delete the manifests, and leave the tests for the future educational purpose?  Or is there an easier way to look them up?

Comment 6

[Martijn Wargers (dead)]

I'd rather not keep unused tests in there inbetween active tests. Then I'd prefer we'd move them to a separate 'obsolete' folder or something.

Comment 7

[Johan Lorenzo [:jlorenzo]]

(In reply to No-Jun Park [:njpark] from comment #5)
> Wonder we discussed this before - but can we just delete the manifests, and
> leave the tests for the future educational purpose?
If we just remove the entries in the manifest, we will end up with dead code. One day, one person may take a look at one test, try to run it and may wonder why it doesn't run. If it's not in the code base anymore, people will have to dig deeper to get them back. So there is no possible confusion if the test doesn't pass at that time, it was not meant to (since it was deleted).

> Or is there an easier way to look them up?
Yes, there are some ways:
* By taking a look at the patch attached to the bug
* By `git log MY_FILE` and then `git show REVISION_FOUND_IN_PREVIOUS_COMMAND:MY_FILE`
* By giving links with revisions. For instance:
  * https://github.com/mozilla-b2g/gaia/blob/80ea294303bc8d456954c0c259ea71d48a7f5e94/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_bookmark.py
  * instead of: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_bookmark.py

Comment 8

[Johan Lorenzo [:jlorenzo]]

Landed in master at: https://github.com/mozilla-b2g/gaia/commit/f6d1cca02eae20d6bc9a494960e7254b2730a2a9

Comment 9

[No-Jun Park [:njpark]]

aha, so the easiest way would be to look up this bug number and take a look at the PR.  So I should remember to search for the 'Delete Test' keyword on Gaia::UI Tests component.  Thanks!