Closed
Bug 1219641
Opened 9 years ago
Closed 9 years ago
Implement *test_delete_all_contacts.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
| feature-b2g | 2.6+ |
People
(Reporter: whsu, Assigned: arcturus)
References
Details
(Whiteboard: [gip-to-gij])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Contacts
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.6+
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → francisco
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8694204 -
Flags: review?(jlorenzo)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8694204 [details] [review] [gaia] arcturus:bug-1219641 > mozilla-b2g:master This test verifies the same things as the Python one. One way to improve it, could be to use more extensively the Page Object pattern[1]. For example: > contacts.tapSelectAll() > contacts.tapDelete() > contacts.tapConfirmDelete() > > assert.ok(contacts.isNoContactsMessageDisplayed) This would reduce the need to comment every line. However, the current test is written with the same style as the other Contacts Gij tests. Then implementing that pattern would introduce some heavy changes. I'm fine if they are done in a follow-up bug. [1] https://wiki.mozilla.org/B2G/QA/Automation/Style_Guide/Best_Practices#The_Page_Object_Pattern
Attachment #8694204 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/64174a5ab27adfc0329d693d867c493a224f4e2c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•