Implement *test_homescreen_column_layout.py* as an integration test in JavaScript

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: whsu, Assigned: cwiiis)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.6+)

Details

(Whiteboard: [gip-to-gij])

Attachments

(1 attachment)

(Reporter)

Updated

3 years ago
Component: Gaia::UI Tests → Gaia::Homescreen
feature-b2g: --- → 2.6+
(Assignee)

Comment 1

3 years ago
Test exists: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/test/marionette/layout_test.js
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
I'm not sure these the scenario in the Python test is covered in JavaScript. Is there a test where we verify we can switch to the 4-column-layout?
Flags: needinfo?(chrislord.net)
(Assignee)

Comment 3

3 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> I'm not sure these the scenario in the Python test is covered in JavaScript.
> Is there a test where we verify we can switch to the 4-column-layout?

Good call, this is missing - this would involve both settings and homescreen (the setting change UI is in settings only). If it's not important to test that bit of UI (or if it can be separated from testing the result), we could synthesise the pref change and just test the layout in a homescreen-only test.
Flags: needinfo?(chrislord.net)
Having a test that covers the flow like a user does, would be a good end-to-end test. We can add this test one MJS runs on device. 

For Gij, testing the pref change seems a good approach to me. Reopening as one more test is necessary.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Assignee)

Updated

3 years ago
Assignee: nobody → chrislord.net
Status: REOPENED → ASSIGNED
Created attachment 8695852 [details] [review]
[gaia] Cwiiis:bug1219665-homescreen-test-4col-layout > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8695852 - Flags: review?(gmarty)
Comment on attachment 8695852 [details] [review]
[gaia] Cwiiis:bug1219665-homescreen-test-4col-layout > mozilla-b2g:master

Excellent!
Attachment #8695852 - Flags: review?(gmarty) → review+
(Assignee)

Comment 7

3 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/5164eb2326993c1c34efa4288f87e33272258ae4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Blocks: 1230099
You need to log in before you can comment on or make changes to this bug.