1219666 - Implement *test_homescreen_delete_app_packaged.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app_packaged.py

Comment 1

[Chris Lord [:cwiiis]]

Test exists: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/test/marionette/app_uninstall_test.js

Comment 2

[Johan Lorenzo [:jlorenzo]]

Link correction: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py

In the Python test, we verify that both regular and packaged app can be deleted. Does that distinction still matter in the new homescreen?

Comment 3

[Chris Lord [:cwiiis]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> Link correction:
> https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py
> 
> In the Python test, we verify that both regular and packaged app can be
> deleted. Does that distinction still matter in the new homescreen?

I don't believe it does - I'm going to assume that the WebAPI for uninstalling apps in Gecko is already well-tested (and certainly that'd be the right place to test this given the entry point is the same on the consumer side).

Comment 4

[Johan Lorenzo [:jlorenzo]]

I have not managed to see where we test the deletion of apps in Gecko. The only place I found is [1] which is testing the error cases only.

I agree the best place would be there. In the meantime, maybe we could have this integration test between gaia and gecko, that also checks the packaged app scenario. What do you think, Chris? 

[1] https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_uninstall_errors.html

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> I have not managed to see where we test the deletion of apps in Gecko. The
> only place I found is [1] which is testing the error cases only.
> 
> I agree the best place would be there. In the meantime, maybe we could have
> this integration test between gaia and gecko, that also checks the packaged
> app scenario. What do you think, Chris? 
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/
> test_uninstall_errors.html

I have no objection :) I guess it'd just be a copy-paste of the existing app_uninstall_test but installing a packaged app first. Would you like me to take this?

Comment 6

[Johan Lorenzo [:jlorenzo]]

I guess we can even parameterize the test[1], so we don't have to repeat ourselves. That'd be great if you could :)

Reopening the bug in order to cover the deletion of a packaged app.

[1] http://mochajs.org/#dynamically-generating-tests

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1219666-homescreen-test-uninstall-packaged-app > mozilla-b2g:master

Comment 8

[Guillaume Marty [:gmarty]]

Comment on attachment 8695847 [details] [review]
[gaia] Cwiiis:bug1219666-homescreen-test-uninstall-packaged-app > mozilla-b2g:master

Nice!

Comment 9

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/11b8eb22e954b9b0d036efd503b7a2abfad82039