Implement *test_homescreen_delete_app_packaged.py* as an integration test in JavaScript

RESOLVED FIXED

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: whsu, Assigned: cwiiis)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.6+)

Details

(Whiteboard: [gip-to-gij])

Attachments

(1 attachment)

(Reporter)

Updated

2 years ago
Component: Gaia::UI Tests → Gaia::Homescreen
feature-b2g: --- → 2.6+
(Assignee)

Comment 1

2 years ago
Test exists: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/test/marionette/app_uninstall_test.js
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
Link correction: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py

In the Python test, we verify that both regular and packaged app can be deleted. Does that distinction still matter in the new homescreen?
Flags: needinfo?(chrislord.net)
(Assignee)

Comment 3

2 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> Link correction:
> https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/
> gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py
> 
> In the Python test, we verify that both regular and packaged app can be
> deleted. Does that distinction still matter in the new homescreen?

I don't believe it does - I'm going to assume that the WebAPI for uninstalling apps in Gecko is already well-tested (and certainly that'd be the right place to test this given the entry point is the same on the consumer side).
Flags: needinfo?(chrislord.net)
Blocks: 1223012
I have not managed to see where we test the deletion of apps in Gecko. The only place I found is [1] which is testing the error cases only.

I agree the best place would be there. In the meantime, maybe we could have this integration test between gaia and gecko, that also checks the packaged app scenario. What do you think, Chris? 

[1] https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_uninstall_errors.html
(Assignee)

Comment 5

2 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> I have not managed to see where we test the deletion of apps in Gecko. The
> only place I found is [1] which is testing the error cases only.
> 
> I agree the best place would be there. In the meantime, maybe we could have
> this integration test between gaia and gecko, that also checks the packaged
> app scenario. What do you think, Chris? 
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/
> test_uninstall_errors.html

I have no objection :) I guess it'd just be a copy-paste of the existing app_uninstall_test but installing a packaged app first. Would you like me to take this?
I guess we can even parameterize the test[1], so we don't have to repeat ourselves. That'd be great if you could :)

Reopening the bug in order to cover the deletion of a packaged app.

[1] http://mochajs.org/#dynamically-generating-tests
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
No longer blocks: 1223012
(Assignee)

Updated

2 years ago
Assignee: nobody → chrislord.net
Status: REOPENED → ASSIGNED
Created attachment 8695847 [details] [review]
[gaia] Cwiiis:bug1219666-homescreen-test-uninstall-packaged-app > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8695847 - Flags: review?(gmarty)
Comment on attachment 8695847 [details] [review]
[gaia] Cwiiis:bug1219666-homescreen-test-uninstall-packaged-app > mozilla-b2g:master

Nice!
Attachment #8695847 - Flags: review?(gmarty) → review+
(Assignee)

Comment 9

2 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/11b8eb22e954b9b0d036efd503b7a2abfad82039
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Blocks: 1230099
You need to log in before you can comment on or make changes to this bug.