1219683 - Implement *test_music_{album,artist,song}_mp3.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/music/test_music_album_mp3.py

Comment 1

[Hubert Figuiere [:hub]]

I'm sure we can combine this with bug 1219684 and bug 1219687. It is already mostly tested.

Comment 4

[Hubert Figuiere [:hub]]

Also dealing with artist and songs. See duped bugs.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1219683-gip-views-tests > mozilla-b2g:master

Comment 6

[Hubert Figuiere [:hub]]

Shall I remove the .py from the repository or will it be done separately?

Comment 7

[William Hsu [:whsu]]

(In reply to Hubert Figuiere [:hub] from comment #6)
> Shall I remove the .py from the repository or will it be done separately?

Hi, Johan,

Can you help answer this question?
Thank you.

Comment 8

[Johan Lorenzo [:jlorenzo]]

This will be done separately. There are some tests we would like to keep, because they don't behave the same way on device, and for now, we have no tests periodically running on device with MarionetteJS.

There are some page classes that can't be removed, because they are use by other projects like AreWeFastYet. 

Hence, let's track the removal in bug 1222975.

Comment 9

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/f1b4fdcdd2b466edbc6a216b018f007d3e4aa487

Comment 10

[Johan Lorenzo [:jlorenzo]]

Thank you for adding these tests.

The Python one also verifies that the music is playing by checking the evolution of the timestamp[1]. I agree it'd be better to have 2 integration tests. The playing scenario looks cover by [2], which is currently skipped because of bug 1032037. Bug 1032037 looks out of date. Hub, do you think we can reactivate that test?

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/music/regions/player_view.py#L97 . Please note this function is not perfect, as this causes bug 1201880. One safer way to make sure the timestamp evolves is to wait for the value to change. 
[2] https://github.com/mozilla-b2g/gaia/blob/2f630f649bb2cb09be1f7527b207161c8972bad0/apps/music/test/marionette/Player_test.js#L94

Comment 11

[Hubert Figuiere [:hub]]

Filed bug 1228130 for that.