Closed
Bug 1219688
Opened 9 years ago
Closed 9 years ago
Implement *test_settings_change_keyboard_language.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
| feature-b2g | 2.6+ |
People
(Reporter: whsu, Assigned: scottwu)
References
Details
(Whiteboard: [gip-to-gij])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Settings
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.6+
|
||
Comment 1•9 years ago
|
||
Scott, would you be able to verify if this test is already covered in Gij, and rewrite that into Gij if not? Thanks!
Flags: needinfo?(scwwu)
|
|
||
Updated•9 years ago
|
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
Flags: needinfo?(scwwu)
|
||
Comment 2•9 years ago
|
||
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8684159 [details] [review]
[gaia] scottwu:1219688-gij-change-keyboard-language > mozilla-b2g:master
Gip used the Contacts app for testing input. I created a test keyboard app in the settings and used it instead.
Please take a look, thanks!
Attachment #8684159 -
Flags: review?(timdream)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8684159 [details] [review]
[gaia] scottwu:1219688-gij-change-keyboard-language > mozilla-b2g:master
Nice work! I don't have a strong opinion other than.
https://github.com/mozilla-b2g/gaia/pull/33039/files#r44258265
Please make sure we don't end up with false positive results by assert something that can be trusted.
Attachment #8684159 -
Flags: review?(timdream) → feedback+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Made some changes. Now uses the test app from keyboard, and addressed the comments on github.
Thanks!
|
|
Assignee | |
Comment 6•9 years ago
|
||
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•