1219688 - Implement *test_settings_change_keyboard_language.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_change_keyboard_language.py

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Scott, would you be able to verify if this test is already covered in Gij, and rewrite that into Gij if not? Thanks!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1219688-gij-change-keyboard-language > mozilla-b2g:master

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8684159 [details] [review]
[gaia] scottwu:1219688-gij-change-keyboard-language > mozilla-b2g:master

Gip used the Contacts app for testing input. I created a test keyboard app in the settings and used it instead.

Please take a look, thanks!

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8684159 [details] [review]
[gaia] scottwu:1219688-gij-change-keyboard-language > mozilla-b2g:master

Nice work! I don't have a strong opinion other than.

https://github.com/mozilla-b2g/gaia/pull/33039/files#r44258265

Please make sure we don't end up with false positive results by assert something that can be trusted.

Comment 5

[Scott Wu [:scottwu]]

Made some changes. Now uses the test app from keyboard, and addressed the comments on github.
Thanks!

Comment 6

[Scott Wu [:scottwu]]

Merged to master.