1228972 - Delete tests already ported to Gij - round #1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

These tests don't require to be tested on device, they just check the integration in either gaia, or gecko and gaia. They have already been ported to Gij.

See dependent bugs to get the list.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1228972 > mozilla-b2g:master

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8693515 [details] [review]
[gaia] JohanLorenzo:bug-1228972 > mozilla-b2g:master

I propose to delete them, because they don't test anything device-specific. Please tell me if you don't think some of them are.

I also checked the Gij tests have parity with the ones I propose to delete.

There are 9 commits in this PR: 1 per app; this should make things easier to rollback (if needed) and to review.

The only page class I modified is cards_view.py as there were some unused dependencies.

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8693515 [details] [review]
[gaia] JohanLorenzo:bug-1228972 > mozilla-b2g:master

seems like they shouldn't behave differently on b2g sim.  But just to state the obvious, if they do, we should reinstate these tests.

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to No-Jun Park [:njpark] from comment #4)
Agreed. Worst case scenario, they still exist in Git and we can get them back easily.


Landed in master at https://github.com/mozilla-b2g/gaia/commit/2332bbc9a1dc5eff5bb1040df8599582a9f6a7d5