1219690 - Implement *test_settings_change_ring_tone.py* as an integration test in JavaScript

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_change_ring_tone.py

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1219690-gij-change-ring-tone > mozilla-b2g:master

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8685303 [details] [review]
[gaia] scottwu:1219690-gij-change-ring-tone > mozilla-b2g:master

Hello Jim, I've just written a test that changes ringtone in Settings app, which was originally implemented in python.

I saw that you've written a lot of tests for the Ringtone app. Wonder if you could take a look, and see if it's okay?

Thanks! :)

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8685303 [details] [review]
[gaia] scottwu:1219690-gij-change-ring-tone > mozilla-b2g:master

This looks fine, but we already have a test that covers this in the Ringtones app: <https://github.com/mozilla-b2g/gaia/blob/master/apps/ringtones/test/marionette/pick_test.js#L169-L195>. Since we already have test coverage, I don't think this patch is really needed, but it's up to you.

Comment 4

[Scott Wu [:scottwu]]

Oh I didn't see that!

I guess it's slightly different in that the test starts from the Settings app, but yes it's pretty similar.

I don't need this in if it's already sufficiently covered. What do you think William?

Comment 5

[William Hsu [:whsu]]

(In reply to Scott Wu [:scottwu] from comment #4)
> Oh I didn't see that!
> 
> I guess it's slightly different in that the test starts from the Settings
> app, but yes it's pretty similar.
> 
> I don't need this in if it's already sufficiently covered. What do you think
> William?

I agree with you.
Let's mark bug as RESOLVED INVALID.