1219694 - Implement *test_inter_app_comm.py* as an integration test in JavaScript

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_inter_app_comm.py

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

We use IAC extensively in our rocketbar and search app tests. I don't think we need to test the bare bones IAC functionality independently because those aforementioned tests would fail if IAC stopped working to spec.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Thanks for the explanation. Having an integration test for IAC might, indeed, sound like wearing belt and suspenders. On the other hand, what would happened if one day the rocketbar and the search app don't use IAC anymore? Do you think having IAC-specific integration tests can help to make sure this feature is covered?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> On the other hand, what
> would happened if one day the rocketbar and the search app don't use IAC
> anymore? Do you think having IAC-specific integration tests can help to make
> sure this feature is covered?

I see your point, here's my take: For making sure an API has test coverage, this is the responsibility of the platform. And indeed there are tests that cover IAC in gecko ([1] for instance). Integration tests in Gaia are not for covering APIs specifically (otherwise we'd need *a lot* more tests here), but rather to test UI interactions in Firefox OS. So instead of having tests for, say navigator.mozApps.mgmt.getAll(), we have integration tests against the app update flow, or in the homescreen to make sure all the icons show up. On the flip side, if we get to the point where no features in Gaia use IAC, there is no point to having the IAC bare bones test. So let's use Gij to test features, not APIs.

1.) https://mxr.mozilla.org/mozilla-central/source/dom/apps/tests/unit/test_inter_app_comm_service.js

Comment 4

[Johan Lorenzo [:jlorenzo]]

Makes sense. Thanks again for the details

Closing as WONTFIX because no Gij equivalent will be implemented.