1219695 - Implement *test_privileged_app_contacts_prompt.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_privileged_app_contacts_prompt.py

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Johan,

Is this test still valid? On a fresh build, if I open the UI tests - Priviliged app and go to "API/contacts" and then click "Insert fake contacts," I don't get a permission prompt. I see in the test that when we set up the profile we set the permissions level to "prompt," but looking at MDN [1] prompt should be the default. Do you know what is happening here?


1.) https://developer.mozilla.org/en-US/Apps/Build/App_permissions

Comment 2

[Johan Lorenzo [:jlorenzo]]

Thanks for calling this out. This test was added in bug 948826 (as a result of bug 853356 comment 214). When the final patch landed, the contacts prompt was already forced[1].

However, the patch was backed out a couple of times before having it final form. It busted the builds. At [2], you can see the prompt not being explicitly set. None of the comments bug 948826 mentions this change. 

Based on the documentation and what happens on other products, I would expect the prompt to be displayed.

Bug 853356 regressed the contacts prompt. Maybe we had another regression before that test landed. NI'ing Al, who might remember the context at that time.


[1] https://github.com/mozilla-b2g/gaia/blob/9dced7f167784e330e4b67991d8ead934eb697ba/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_privileged_app_contacts_prompt.py#L14
[2] https://github.com/mozilla-b2g/gaia/blob/24d9c772fe6eb62e9ad8ae63e6d4b2ed569f6299/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_privileged_app_contacts_prompt.py

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Sounds like there might be a real bug in the product here. I can't test this functionality until that is fixed. So I'll wait to hear back from Al before moving forward here.

Comment 4

[Al Tsai [:atsai]]

Sorry. I took a PTO last Friday and couldn't reply in time. I'll take a look today.

Comment 5

[Al Tsai [:atsai]]

I think it's a bug. We should have a prompt while inserting/reading a contact via Privileged app first time.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Based on the branches already impacted (see bug 1227011), this bug likely contains sensitive information. Restricting it to Mozilla's employees + cc'd contractors.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Fernando, do you know who handles the contacts permission prompt these days?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Sorry for the noise, it looks like most of the discussion is happening on bug 1219695. Let's move the conversation there and leave this for converting the test.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Looks like the problem mentioned in comment 2 only affects pre-installed privileged apps, so we don't need to protect this one.

Comment 10

[Gregor Wagner [:gwagner]]

This was done on purpose in bug 1014410

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1219695-contacts-prompt-test > mozilla-b2g:master

Comment 12

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8695540 [details] [review]
[gaia] mikehenrty:bug-1219695-contacts-prompt-test > mozilla-b2g:master

Guillaume, could you take a look here?

Comment 13

[Guillaume Marty [:gmarty]]

Comment on attachment 8695540 [details] [review]
[gaia] mikehenrty:bug-1219695-contacts-prompt-test > mozilla-b2g:master

Looks good to me!

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/6137497044ae1c24c06383caec6121567d64bf18