Closed Bug 1219708 Opened 9 years ago Closed 9 years ago

Should not attempt to sync while offline

Categories

(Firefox OS Graveyard :: Sync, defect, P3)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1219708.nosync.offline > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
mbdejong
: review+
Details | Review 
      No description provided.
Blocks: fxos-sync
Priority: -- → P3
Target Milestone: --- → FxOS-S10 (30Oct)
Assignee: nobody → ferjmoreno
Attachment #8681395 - Flags: review?(yliao)
Attachment #8681395 - Flags: review?(mbdejong)
Comment on attachment 8681395 [details] [review]
[gaia] ferjm:bug1219708.nosync.offline > mozilla-b2g:master

Thank you! Just curious if we should trigger an error when offline. Please request approval for v2.5 when finished.
Attachment #8681395 - Flags: review?(yliao) → review+
The sync attempts are done in the background, so we shouldn't show any error to the user. With manual sync requests, we show errors when the server is not available.
Attachment #8681395 - Flags: review?(mbdejong) → review+
https://github.com/mozilla-b2g/gaia/commit/519d03420e2d9e9ff2924ea04fba584e47a1756c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: