1220101 - “Add-ons” option from the new-nav disappears after accessing Rev Tools on FF OS 2.5

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Valentina Virlics [:vvalentina], VPN QA]

Steps to reproduce:
1. Load MP-dev on your FF OS 2.5 device
2. Observe the new navigation options (Add-ons option available)
3. Go to Reviewer Tools
4. Return to Consumer Pages
5. Observe the new-nav options

Expected results:
The options are the same like before going to Reviewer Tools.

Actual results:
The Add-on option is missing.

Notes/Issues:
If the MP app is restarted the option re-appears.
Verified on FF OS 2.5. Issue is reproducing on MP-dev.
Ashes ID: 3ca40

Comment 1

[Mathieu Pillard [:mat]]

addonsEnabled, homescreensEnabled and lateCustomizationEnabled are passed as query parameters from the package to the iframe. This bug happens because the link from reviewer tools does not contain those parameters :(

I think the proper way to fix that is to store those parameters in localStorage. Otherwise we'd have to pass them to reviewer tools/devhub, which would need to remember them, to pass them again later when going back to consumer pages :(

Comment 2

[Valentina Virlics [:vvalentina], VPN QA]

This issue is also reproducing in MP-prod using FF OS 2.5., if instead of Reviewer Tools page we access Content Tools page.

Comment 3

[Davor Spasovski [:spasovski]]

For reviewers it's recommended you "always enable firefox os add-ons" via the debug page. This gets stored into localStorage and will persist.

Comment 4

[David Durst [:ddurst]]

> Steps to reproduce:
> 1. Load MP-dev on your FF OS 2.5 device
> 2. Observe the new navigation options (Add-ons option available)
> 3. Go to Reviewer Tools
> 4. Return to Consumer Pages
^^^ How do you do this from inside the app?

> 5. Observe the new-nav options

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to David Durst [:ddurst] from comment #4)
> > Steps to reproduce:
> > 1. Load MP-dev on your FF OS 2.5 device
> > 2. Observe the new navigation options (Add-ons option available)
> > 3. Go to Reviewer Tools
> > 4. Return to Consumer Pages
> ^^^ How do you do this from inside the app?
> 
> > 5. Observe the new-nav options

I access any app review page and tap "view listing" :)

And, yes, if I check "always enable firefox os add-ons" from :debug, the issue is no longer reproducible....but how does it work for a "normal" user, Davor?

Comment 6

[Davor Spasovski [:spasovski]]

Reviewers are a limited subset of normal users so I don't think it's a big deal - they can be told this info beforehand. The STRs are not necessarily the exact path reviewers might take anyway...I don't think this bug is worth the effort to properly address however we can revisit it if it turns out to be a pain point for reviewers.

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

It is not a "big deal" for me, because I am a reviewer, so... if you guys think is not a big deal that a regular user is not able to access "Add-ons" option from the menu every time he wants, I'm good.