1220195 - WebIDE-installed add-ons don't appear in the add-on settings until Settings is restarted

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

+++ This bug was initially created as a clone of Bug #1215546 +++

Bug 1215546 fixed this problem for Marketplace add-ons by listening to the 'downloadsuccess' event. However, this doesn't work for WebIDE since that event never fires. We'll need to figure out an alternative path here for WebIDE, since this is quite annoying for add-on developers.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Looks like this was caused by bug 1215546. Fair enough since fixing this for the user case comes before developer case.

Scott, do you want to have a look at this?

Comment 2

[Scott Wu [:scottwu]]

Sorry didn't test the patch with WebIDE when I fixed the user case.

I've fixed it and will submit a patch for review later.

Thanks for reporting this :)

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1220195-addons-dont-appear-WebIDE > mozilla-b2g:master

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8681847 [details] [review]
[gaia] scottwu:1220195-addons-dont-appear-WebIDE > mozilla-b2g:master

Fixed the issue caused by Bug 1215546. Added a check to see if it's installed via marketplace or WebIDE. Thanks!

Comment 5

[[e-mail]]

[Blocking Requested - why for this release]: annoy if not available for addon developers

Comment 6

[[e-mail]]

Comment on attachment 8681847 [details] [review]
[gaia] scottwu:1220195-addons-dont-appear-WebIDE > mozilla-b2g:master

Yura could you help review it?

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8681847 [details] [review]
[gaia] scottwu:1220195-addons-dont-appear-WebIDE > mozilla-b2g:master

Thanks, r+ with a couple of comments.

Comment 8

[Scott Wu [:scottwu]]

Thanks for reviewing Yura!
I've changed the test both installing from WebIDE and Marketplace.

Comment 9

[SandKing]

This bug has been verified as pass on latest build of Flame kk v2.6 and Aries kk v2.6 by the STR in comment 0.

Actual result: The add-on which you add from WebIDE will appear in add-ons list immediately.

See attachment: Verified_Aries_v2.6.3gp
Reproduce rate: 0/10

Device: Flame kk v2.6 512mb (master) (Pass)
Build ID               20151110150205
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151110.182433
Firmware Date          Tue Nov 10 18:24:47 EST 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

Device: Aries kk v2.6(master) (Pass)
Build ID               20151110120047
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.111927
Firmware Date          Tue Nov 10 11:19:35 UTC 2015
Bootloader             s1