1215546 - Marketplace-installed add-ons don't appear in the add-on settings until the device is rebooted

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Chris Mills [:cmills]]

When I installed the Homebar-Plus extension from the experimental new marketplace extensions hosting, it was enabled and worked fine straight away, but the add-on details screen in the Settings app didn't appear.

I had to restart the phone for it to appear.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

This needs to block.

Yura, do you have any bandwidth to investigate what's going on here? FWIW, this seems to work from Hackerplace, so I'm not sure what's going on.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Michael Henretty [:mhenretty] from comment #1)
> This needs to block.
> 
> Yura, do you have any bandwidth to investigate what's going on here? FWIW,
> this seems to work from Hackerplace, so I'm not sure what's going on.

Seems to work for me with latest master. One thing I noticed is that list is cached if Settings are open. If app is started anew it lists fine.

Comment 3

[[e-mail]]

Can reproduce on latest OTA, will check it further tomorrow

Comment 4

[[e-mail]]

test with Hackerplace and got the same result. kill Settings then restart it, the list is updated.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

It looks like the reset of the underlying observable array here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/addons/addons_list.js#L43
does not get to the list view.

Comment 7

[[e-mail]]

==== clone from bug 1216075 comment 7 ====

Scott found when addon list successfully received the `oninstall` event and the listview is ready to reflesh the list. 

But **the addon related information is not ready yet** (can't get from the manifest). 

After adding some delay on oninstall event handler, the manifest can be processed correctly (but the delay time depends on device). Therefore it's more reasonable to fix on gecko side.


Fabrice could you help finding a proper person to take a look on this issue?

Comment 8

[[:fabrice] Fabrice Desré]

That's the expected behavior of the mozApps api. When you call installPackage(), we fire an `install` once the user accepts the installation, but before we are done with downloading the package. For instance, the homescreen will show an icon with a throbber during this phase. At this point only the update manifest is available.

Once the package has been downloaded, we fire another event (`downloadsuccess`) and this is when you can access the full manifest.

Comment 9

[Scott Wu [:scottwu]]

Thanks Fabrice! I got it working successfully now.

Didn't know there's an event for that and couldn't find the doc for it. Think I saw the 'downloadsuccess' event somewhere but listened to it incorrectly on mozApps.mgmt instead of the installed app.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1215546-addons-dont-appear-settings > mozilla-b2g:master

Comment 11

[Scott Wu [:scottwu]]

Comment on attachment 8679301 [details] [review]
[gaia] scottwu:1215546-addons-dont-appear-settings > mozilla-b2g:master

Only changed a few lines. Please take a look when you have time. Thanks!

Comment 12

[[e-mail]]

Comment on attachment 8679301 [details] [review]
[gaia] scottwu:1215546-addons-dont-appear-settings > mozilla-b2g:master

Looks good, thanks scott!

Comment 13

[Scott Wu [:scottwu]]

Merged.

Thanks everyone!

Comment 14

[Queena.Wen(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK 2.5&Flame KK 2.5 by the steps.

Steps:
1. Launch "Settings"->"Add-ons".
2. Tap "Get More add-ons". 
3. Press install button to install any add-on. 
4. Install add-on and back to add-ons list view.

Actual results: In step 4, the installed Add-on appears in installed add-on list immediately. 
See attachment: verified_Aries KK_v2.5.3gp.
Reproduce rate: 0/10.

Device: Aries KK v2.5 (Pass)
Build ID               20151029010303
Gaia Revision          75f2236d36cc9f9c02d3596fae3de014007cfd82
Gaia Date              2015-10-28 17:02:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e700005a0ddf2b17803213e1f3f8d78a7a618b8
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151029.002011
Firmware Date          Thu Oct 29 00:20:19 UTC 2015
Bootloader             s1

Device: Flame KK v2.5 (Pass)
Build ID               20151028150209
Gaia Revision          2e89362de40a6c9c36525d36317fa1ae8e67e143
Gaia Date              2015-10-28 04:56:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/fc706d376f0658e560a59c3dd520437b18e8c4a4
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151028.182746
Firmware Date          Wed Oct 28 18:27:57 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Queena.Wen(Leave from Mozilla)]

Attachment: verified_Aries KK_v2.5.3gp