1220512 - Intermittent test_playback.html | split.webm checking readyState - got 4, expected 2

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=16236257

 01:47:00     INFO -  44279 INFO [finished redirect.sjs?domain=mochi.test:8888&file=320x240.ogv-33] remaining= seek.webm-34
 49131 
 01:47:00     INFO -  44280 INFO TEST-PASS | dom/media/test/test_playback.html | [finished redirect.sjs?domain=mochi.test:8888&file=320x240.ogv-33] Length of array should match number of running tests
 49132 
 01:47:00     INFO -  44281 INFO TEST-PASS | dom/media/test/test_playback.html | [started split.webm-35] Length of array should match number of running tests
 49133 
 01:47:00     INFO -  44282 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm: Name should match #1
 49134 
 01:47:00     INFO -  44283 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm duration (1.967) should be around 1.967
 49135 
 01:47:00     INFO -  44284 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm isEncrypted should be true if we have decryption keys
 49136 
 01:47:00     INFO -  44285 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm: Name should match #3
 49137 
 01:47:00     INFO -  44286 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm: Name should match #2
 49138 
 01:47:00     INFO -  44287 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm duration (2.001) should be around 1.967
 49139 
 01:47:00     INFO -  44288 INFO TEST-PASS | dom/media/test/test_playback.html | split.webm isEncrypted should be true if we have decryption keys
 49140 
 01:47:00     INFO -  44289 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_playback.html | split.webm checking readyState - got 4, expected 2

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/96377bdbcdf3/dom/media/MediaDecoderStateMachine.cpp#l731

For a video-only file, next frame status is updated in OnVideoPopped() which sometimes comes after MediaDecoder::PlaybackEnded() is notified. Therefore, we get an outdated readyState in the 'ended' event handler.

The fix is simple by call UpdateNextFrameStatus() before notifying MediaDecoder::PlaybackEnded() to ensure readyState is updated again before 'ended' fired.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1220512 - ensure next frame status is updated before notifying MediaDecoder::PlaybackEnded. See bug 1220512 comment 1 for the detail. r=cpearce.

Bug 1220512 - ensure next frame status is updated before notifying MediaDecoder::PlaybackEnded. See bug 1220512 comment 1 for the detail. r=cpearce.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8681755 [details]
MozReview Request: Bug 1220512 - ensure next frame status is updated before notifying MediaDecoder::PlaybackEnded. See bug 1220512 comment 1 for the detail. r=cpearce.

https://reviewboard.mozilla.org/r/23877/#review21433

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ba9c5fee9a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9ba9c5fee9a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a9ba9c5fee9a

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 11

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 3
* mozilla-inbound: 2
* fx-team: 1

Platform breakdown:
* b2g-emu-ics: 3
* linux64: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1220512&startday=2015-11-09&endday=2015-11-15&tree=all