the accessible-app-icon aria string is incorrect

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin, Assigned: ralin)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [good first bug][mentor-lang=zh][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
followup of Bug 1144426,

the accessible-app-icon aria string

accessible-app-icon.ariaLabel=Icon for {{appName}} app

should just be: {{appName}} app
(Reporter)

Updated

3 years ago
tracking-b2g: --- → backlog
Depends on: 1144426
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
(Assignee)

Comment 1

3 years ago
Hi,

I'd like to take this bug, if possible. 

Thanks.
(Reporter)

Comment 2

3 years ago
sure! thanks for help
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Created attachment 8682970 [details] [review]
[gaia] raylin:1220532-incorrect-accessible-string > mozilla-b2g:master
(Assignee)

Comment 4

3 years ago
Comment on attachment 8682970 [details] [review]
[gaia] raylin:1220532-incorrect-accessible-string > mozilla-b2g:master

1. Fix incorrect string as the way in comment 
2. Change ID from 'accessible-app-icon' to 'accessibility-app-icon'

Also tested with screen reader on a physical device.
Attachment #8682970 - Flags: review?(gasolin)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8682970 [details] [review]
[gaia] raylin:1220532-incorrect-accessible-string > mozilla-b2g:master

look good, thanks!
Attachment #8682970 - Flags: review?(gasolin) → review+
(Reporter)

Comment 6

3 years ago
merged https://github.com/mozilla-b2g/gaia/commit/1fb7e4b7904d577a1859b91269a85b363ddc2836
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.