1220563 - [Toaster] In LTR, text is right-aligned when notification created with dir="rtl"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Augustin Trancart [:autra]]

Attachment: toaster_title_body_alignment.png

[Steps]
- put your phone in English
- connect your phone to the webIDE, with the System app
- create a new notification with a dir 'rtl', for example by executing
> new Notification('مسيبمن', {body: 'body', icon: 'http://icdn.pro/images/fr/1/u/1up-champignon-icone-9299-96.png', dir: 'rtl'})
in the console
- observe the toaster

[Expected]
- The title and body are left-aligned

[Actual]
- The title and body are right-aligned, see toaster_title_body_alignment.png

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master

Comment 2

[Augustin Trancart [:autra]]

Comment on attachment 8681831 [details] [review]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master

Hi Etienne,

A quick patch to correct alignment in toaster. Apparently my patch in bug 1212329 missed this.

Comment 3

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/d2342238a3c9c247fcbd2cb3a46dbb0499904efa

Comment 4

[Augustin Trancart [:autra]]

Comment on attachment 8681831 [details] [review]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: bad RTL experience for notifications
[Testing completed]: on flame
[Risk to taking this patch] (and alternatives if risky): Low, only css change, but should be uplifted AFTER bug 1219618
[String changes made]: none

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8681831 [details] [review]
[gaia] Phoxygen:bug1220563-toaster_alignment > mozilla-b2g:master

Clearing uplift, already in 2.5.