1220678 - "Download Publication" link on ebook demo site crashes e10s nightly

Status: VERIFIED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Visit this site in e10s mode:

  https://jakearchibald.github.io/ebook-demo/publisher-site/readme/

Make the site offline by checking the box in the upper left.  Then click "Download Publication".

Nightly with e10s enabled crashes.

This is because ExternalHelperApp calls DivertToParent() on the channel so that the file can be saved to disk.  With an intercepted channel, however, we do not have a parent actor.  So the IPC operation fails to deserialize and crashes.

I'm going to fix the crash here and file a follow-up to make DivertToParent() work for synthesized responses.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Don't crash when DivertToParent() is called on an intercepted channel. r=jdm

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/097cac1912b9

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8681998 [details] [diff] [review]
Don't crash when DivertToParent() is called on an intercepted channel. r=jdm

Approval Request Comment
[Feature/regressing bug #]: service workers
[User impact if declined]: Users with e10s enabled (mainly aurora/nightly) will experience crashes using sites like https://jakearchibald.github.io/ebook-demo/publisher-site/readme/
[Describe test coverage new/current, TreeHerder]: Local testing that crash does not trigger any more.
[Risks and why]: Minimal risk as it only affects service workers.
[String/UUID change made/needed]: None

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/097cac1912b9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/097cac1912b9

Comment 6

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8681998 [details] [diff] [review]
Don't crash when DivertToParent() is called on an intercepted channel. r=jdm

Seems like a simple patch and has baked in Nightly for a few days, let's uplift to Aurora44.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Florin, would the QE team be able to verify this fix work as expected and there are no unexpected fall outs from it?

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6a47a7d76eb7

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6a47a7d76eb7

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Reproduced the crash with Nightly 45.0a1 2015-11-02 while having "Make worky offline" both checked and unchecked.

Some of the crash reports:
 https://crash-stats.mozilla.com/report/index/dc5ed9ca-ea55-47b6-8bf5-caae72151111
 https://crash-stats.mozilla.com/report/index/bp-5d2354af-94d4-4ca4-aad4-f1d612151111

With current Nightly 45.0a1 2015-11-10 and Aurora 44.0a2 2015-11-11 builds, there are no crashes, but the following pop-up shows up when choosing the "Download publication" link: 

Downloading 
could not be saved, because the source file could not be read.

Try again later, or contact the server administrator.

Is this expected?

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #11)
> Reproduced the crash with Nightly 45.0a1 2015-11-02 while having "Make worky
> With current Nightly 45.0a1 2015-11-10 and Aurora 44.0a2 2015-11-11 builds,
> there are no crashes, but the following pop-up shows up when choosing the
> "Download publication" link: 
> 
> Downloading 
> could not be saved, because the source file could not be read.
> 
> Try again later, or contact the server administrator.

Yes.  This bug only fixed the crash, but we need bug 1220681 to truly fix the site on e10s.  So this looks verified to me.

Thanks!

Comment 13

[Petruta Horea [:phorea], Desktop QA]

Thank you!

Comment 11 was referring to Win 7 64-bit.
I checked that the same behavior occurs under Mac OS X 10.11 and Ubuntu 14.04 64-bit.