122070 - [FIX][Mach] Can not close page info dialog

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect, P1)

Description

[Marcus Pallinger]

There is no way to close the Page Info dialog on the Macho-o build of Mozilla.

The red close button (tht thing on the top left) is greted out (only minimize
and maximize) and there is no ok button or any other buton to click.

Source was up to date as of 01/27/2002 01:08.

.mozconfig:
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --enable-optimize
ac_add_options --with-glib-prefix=/sw
ac_add_options --with-libIDL-prefix=/sw
ac_add_options --disable-mailnews
ac_add_options --enable-plaintext-editor-only

mk_add_options MOZ_CVS_FLAGS="-q -z9 -d :pserver:[e-mail]
g:/cvsroot"

Comment 1

[Marcus Pallinger]

(that checkout time was http://bonsai.mozilla.org time)

Comment 2

[Håkan Waara]

->db48x

Comment 3

[Daniel Brooks [:db48x]]

First, what's mach-o? Second what window manager greys out the close button?
That's usually not optional.

Comment 4

[Marcus Pallinger]

Mach-o is one of the ways to build Mozilla on Mac OSX, using the unix build
system (gmake, and co) but using some Mac specific stuff. In the end you end up
with a native Mac application, so It's Mac OSX's native window manager.

Note. this works fine on the CFM build 2002012503
(For more information on mach-o, you can look at
http://www.mozilla.org/ports/fizzilla/ but I'm nto sure how helpful that would be.

The greying out of the close button is specific to some dialogs

ccing Zach.

Comment 5

[Daniel Brooks [:db48x]]

I thought it was a mac thing. I'll need a mac person to take a look at it.

Comment 6

[R.K.Aa.]

related: bug 81657

Comment 7

[Zach Lipton [:zach]]

qa for mach-o bugs belongs to me at this time because most qa contacts 
do not have access to mach-o builds.

Comment 8

[Zach Lipton [:zach]]

qa back to me

Comment 9

[Boris Zbarsky [:bzbarsky]]

So... we should consider adding "close" to the option list we pass to openDialog
when opening pageinfo

Comment 10

[Alex Stewart]

Confirming.  I just saw this in a CVS build built on Mar 11.

Comment 11

[Boris Zbarsky [:bzbarsky]]

any traction here?  Can someone with a mach-o tree try what I suggest in comment
9?  No build environment required, even; it's a JS-only change....

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 172463 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: the patch.... someone needs to test this

Comment 14

[hacker formerly known as [e-mail]]

Comment on attachment 103926 [details] [diff] [review]
the patch.... someone needs to test this

r=cls pending ongoing discussion of possible deeper widget issue.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: alternate approach

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: More like this, actually

Comment 17

[Boris Zbarsky [:bzbarsky]]

cls says that fixes the bug.  Taking, with your permission, Daniel.

reviews?  pinkerton?  bryner?    As bryner suspected, uninitialized vars were
the problem.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 103926 [details] [diff] [review]
the patch.... someone needs to test this

this patch is bogus.

Comment 19

[Brian Ryner (not reading)]

Comment on attachment 103944 [details] [diff] [review]
More like this, actually

sr=bryner. good catch.

Comment 20

[hacker formerly known as [e-mail]]

Comment on attachment 103944 [details] [diff] [review]
More like this, actually

r=cls

Comment 21

[Mike Pinkerton (not reading bugmail)]

looks good. r=pink

Comment 22

[Christopher Blizzard (:blizzard)]

Comment on attachment 103944 [details] [diff] [review]
More like this, actually

a=blizzard on behalf of drivers for 1.2final.

Comment 23

[Boris Zbarsky [:bzbarsky]]

fixed on trunk.