Closed Bug 81657 Opened 24 years ago Closed 16 years ago

The page info does not have a close button

Categories

(SeaMonkey :: Page Info, defect)

Product:
SeaMonkey
Component:
Page Info
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: nitinp, Assigned: db48x)

References

Details

I am using the 20001051720 build of Netscape6. When I open the page info page from the lock I do not see a close button. I have to click on the cross in the top right to close the page. There should be a close button there to close the page.
Target Milestone --- -> 2.0.
Target Milestone: --- → 2.0
/me shrugs. People are split about 50/50 on whether it needs such a close button.
Blocks: 52730
Logically a user will look for a close button for any window which will open up. Yes in the end he/she will realize and close it somehow, but how difficult will it to be to put a close button in the window.
No longer blocks: 52730
changing product->Browser
Component: Client Library → Browser-General
Product: PSM → Browser
Target Milestone: 2.0 → ---
Version: 2.0 → other
-> XP Apps: GUI Features
Assignee: ddrinan → blake
Component: Browser-General → XP Apps: GUI Features
QA Contact: junruh → sairuh
Matthew: close button fun!
--> UI Design
Assignee: blake → mpt
Component: XP Apps: GUI Features → User Interface Design
QA Contact: sairuh → zach
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
We don't have an extra `Close' button at the bottom of Navigator windows, or mail/news three-pane windows, or message composition windows, or view source windows. And all of those are `windows which will open up'. Wherever there is a `Close' button in *any* window, there's something wrong with the UI design. WONTFIX.
*** Bug 148301 has been marked as a duplicate of this bug. ***
I still think that the window should have a Close/Ok button as it appears quite different from navigator, mailnews windows to the user. It is more along the lines of the preferences window, password manager etc. All of those have Ok / Cancel / Help buttons, but since there is nothing to cancel in the page info dialog it only needs the ok and help buttons. Ok to dismiss it and help to bring up relevant help topics. It's a very simple fix as well. I already provided something simple in bug 148301
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
I also think that a Close button would be _very good_ in this dialog.. A Close button would imho logical.. look at some other dialogs: Preferences: Has: Ok, Cancel, Help ..who will close this dialog with the 'x' button?.. What would happen? nobody knows.. so the user will use 'Ok' (To save & Close) or Cancel (just close) Find in this page: Has a Find and a Cancel button.. The Cancel button is bigger than the 'x', so my grandma would use the 'Cancel' button to close the window.. Save As Dialog: has Save and Cancel. If you would like to close the window without saving, do you hit the little 'x' ? My grandma would use the Cancel button.. and does granny know, that hitting 'x' wouldn't save the page? maybe --- The Page Info dialog looks complex (It is so complex that it needs a help button!).. A user could also think that he could change something in this dialog.. If he/she/it hits the 'x', would mozilla save the settings? nobody knows (..ok.. we know that mozilla wouldn't save anything of course..) The 'Help' button is also very alone in this dialog.. I don't know why, but i hit very often the Help button when i would like to close the Page Info windows.. I also saw 3-4 times that other users also clicked on the 'Help' button in this dialog when they wanted to close the window.. And imho it's also logical to close such a dialog with something wich is placed on the bottom... How do you read the information in the dialog? ______________ |__________x_| | | <--- you will start reading here.. | | | | | | | | <--- when you are finished, you are here.. |__close|help| <--- now you are tired, would you like to move the mouse up to little, hard to catch 'x' button or would you like to press the big close button wich is very near to you? .. i would prefer the 'close' button.. :)
You have a good point about the Help button. It's confusing you into thinking that the Page Info window is a dialog, when it's not. I filed bug 160694 on getting rid of the Help button.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → WONTFIX
I think the real solution to this problem isn't just removing/adding a single button, but perhaps changing the way page info looks. Is there a better way mpt? The navigator and mail windows don't need a close button because they have toolbars and menus, which is where people expect that sort of thing, at least in a main program window like that. I really don't think the page info window counts as a dialog, but it's not a main program window either, so I think adding a close button is the easiest way to fix the problem.
missed the reopen box
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
*** Bug 166864 has been marked as a duplicate of this bug. ***
Please set OS and Platform to ALL. See Bug 166864
OS: Windows 2000 → All
Hardware: PC → All
NoItShouldNotHaveACloseButton(tm): http://mpt.phrasewise.com/2002/09/04#a332
Assignee: mpt → db48x
Status: REOPENED → NEW
Component: User Interface Design → Page Info
QA Contact: zach → pmac
*** Bug 172757 has been marked as a duplicate of this bug. ***
Of course all windows should have a way to close them! I am an experienced computer user and I had trouble closing that d*mned popup, so please think of how a newbie will react. After some swearing and trying, I found the proper way: to press CTRL-W. How intuitive is that?? And please stop talking about clicking the 'x'! Mozilla is a cross-platform tool so please treat it as such! My window manager does not provide any x'es to click on.
*** Bug 174503 has been marked as a duplicate of this bug. ***
I wholeheartedly agree that this window needs a close button. Every time I open this window, I subconsciously start to click the button in the lower-right to close it. I catch myself when I see "Help", and I'm momentarily frustrated. The cookie manager, image manager, password manager, etc. all have close buttons. This is a simple UI consistency issue. That button NEEDS to be there. I was about to file this as a bug, and entered "close button page info" as my search terms. Lo and behold, I'm not the only one who feels this way. heh.
Hm, why does it take so long to add a simple button? You should remove all close buttons from all managers, if this bug isn't going to be fixed :-) Damn, I filed a bug some time ago and it's not even duped against this bug!
I agree completely to Christopher and HJ!! It's kind of a modal dialog (ok, it's not defined modal, but most people use it this way) -> should have a close button like passwd manager etc. Is it really true, that it takes over one year to add a simple close-button? Is this some kind of "religious" discussion like which is the best editor? Please add at least a target milestone and accept it as a bug.
pageInfo.xul is converted into a real dialog, see also: http://bugzilla.mozilla.org/show_bug.cgi?id=226955 All dialog, or none of them, should have a close button :-)
This is all you need: http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/pageInfo.xul#48 - buttons="help" + buttons="help,cancel" http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/pageInfo.xul#327 <button dlgtype="help" class="dialog-button"/> + <button dlgtype="cancel" class="dialog-button" label="&closeButton.label;"/> view-source:chrome://navigator/locale/pageInfo.dtd +<!ENTITY closeButton "Close"> Btw, this bug can't be blocking an invalid bug (bug 82059) so I removed it.
No longer blocks: 82059
This problem seems to have reappeared in the latest Firefox.
Product: Browser → Seamonkey
This bug is present in Deer Park Beta 2 aka Firefox 1.5 Beta 2 aka Firefox 1.4.1. It causes usability problems with certain window managers. Whether you blame Firefox or the window manager is a different story. Fact is that it is not easy or even impossible to close the window with a pointing device when using certain window managers. Some window managers consider it a feature that they do not provide window decorations, for example. Idea: what about making close buttons a configuration setting (which is probably hidden from the UI)?
QA Contact: pmac
> This is all you need: > - buttons="help" > + buttons="help,cancel" In the current implementation we don't have a help button either. WONTFIX.
Status: NEW → RESOLVED
Closed: 22 years ago → 16 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.