1220912 - Unable to add add-on to collection because search spinner is stuck

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

STR:
1) Go to https://addons.mozilla.org/firefox/collections/mozilla/featured-add-ons/edit/#addons-edit
2) Type the name of an add-on in the search box, like "user-agent switcher"
3) Wait...

Observed result:
The spinner keep going round and round, but nothing else happens.

Expected result:
The add-on should show up.

This looks related to bug 1220112, since they're both recent regressions in AJAX-y code.

Comment 1

[krupa raj[:krupa]]

I see TypeError: this._renderItem(...) is undefined common-min.js:3:7574 is undefined in the Console.

Comment 2

[Andy McKay]

Is there something important we need to a collection somewhere? If so we can do that without using the UI.

Comment 3

[Andy McKay]

:nolski, could you take a look please? I think this is related to the jquery upgrade as well

Comment 4

[Christopher Grebs [:cgrebs]]

This could be relevant to PR https://github.com/mozilla/olympia/pull/845 - which needs and will get a smaller update. At least the console error krupa reported should be fixed by this.

Comment 5

[Mike Nolan [:nolski]]

Looks like that's the case to me

Comment 6

[David Hedlund]

Thank you for fixing piece of the problem.

However, when I write "Privacy Settings" to the "Add to Collection" field when I edit a collection, nothing happens.

Comment 7

[krupa raj[:krupa]]

I still see this error on prod.

Comment 8

[David Hedlund]

Seem to be working now.