122102 - Mac OS X Resizable sheets - how to get grow box?

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Robert John Churchill]

Simon was asking about making Mac OS X sheets resizable. After my initial
disbelief (I had never seen such a "beast", as well as nothing in the APIs or
documentation to indicate that they were possible), I have a few code tweaks to
get it to work.

Only one problem seems to be outstanding -- getting the growbox to appear. There
are only two documented sheet-related window procIDs:

kWindowSheetProc      = 1088 /* available in Mac OS X and CarbonLib 1.3 */
kWindowSheetAlertProc = 1120 /* available in Mac OS X after 1.0, and CarbonLib
1.3 */


Steve (Dagley), can you check with Apple to see if there is an undocumented
procID which will produce a sheet with a growbox? Or, barring that, what's the
special sauce required?

Comment 1

[Robert John Churchill]

Attachment: resizable sheets

Patch.

Comment 2

[Steve Dagley]

If you look at an X app like Text Edit you'll see that the Save As... sheet is 
resizable if you toggle between the simple and expanded versions of the Nav 
Services Save As... dialog.  As you say there doesn't seem to be any APIs or 
procIDs for this so it may just be Nav Services magic (and I notice we don't do 
those dialogs as sheets).

On the other hand there is an interesting comment in MacWindows.h talking about 
handling the kEventWindowDrawContent message:

"If you install the standard Carbon window event handler on your sheet window 
(using kWindowStandardHandlerAttribute or InstallStandardEventHandler), the 
standard handler automatically handles this event and calls DrawControls."

Comment 3

[Robert John Churchill]

Since ajfeldman has incorporated my patch into his in bug # 106695, let's use
this bug for tracking how to get the grow box for a resizable sheet.  Updating
summary.

Steve, I'm going to nudge this bug in your direction so that you can ask Apple.

Comment 4

[Steve Dagley]

Response from Apple:

"Just set the Resizable window attribute on the sheet window."

Now that we know how, reassigning to ajfeldman so it can be incorporated in bug # 
106695,

Comment 5

[Ari]

rjc already figured that out. The problem is, as he realized, is that although
the sheet becomes resizable, it doesn't get a resize grippy. I have no idea why.

Comment 6

[Steve Dagley]

Do we attach the standard handler to the window?

Comment 7

[Greg K.]

Fwiw, the Halime newsgroup client has resizable subscription dialog sheet.

Comment 8

[Robert John Churchill]

Comment on attachment 66685 [details] [diff] [review]
resizable sheets

Obsoleting this patch as it was checked in for bug # 130218

Comment 9

[Frankie]

Apparently this has already happened, because bug 163267 is complaining about it.

Comment 10

[Stefan [:stefanh]]

well, bug 163267 hasn't been touched for 5 years and I have never seen a resizer in a sheet. We probably don't want resizable sheets, so this might be invalid

Comment 11

[Markus Stange [:mstange]]

I think it was fixed by bug 130218 and later ported to Cocoa, but I'm not sure.
And I can see a resizer in the Bookmarks -> Bookmark All Tabs... sheet :-)

Comment 12

[Stefan [:stefanh]]

Oh, ok. Sorry. Resoling as wfm again, then.