130218 - Resizable dialogs should retain resizability as sheets

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Greg K.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.9) Gecko/20020310
BuildID:    2002031005

The newsgroup subscription dialog sheet should be resizable. At present, it is not.

Reproducible: Always
Steps to Reproduce:
1. Select a news server in the three-pane window
2. Click "Subscribe to newsgroups."

Actual Results:  A nice Aqua-style dialog sheet is displayed, but it is not
resizable.

Expected Results:  A nice Aqua-style resizable dialog sheet should have been
displayed.

Additional Information:  In general, resizable dialogs transformed into sheets
should retain their resizability.

Comment 1

[Greg K.]

Generalizing Summary a bit.

Comment 2

[Mike Pinkerton (not reading bugmail)]

-> rjc

Comment 3

[Mike Pinkerton (not reading bugmail)]

really to rjc this time

Comment 4

[Robert John Churchill]

<sigh>  I had a patch for this attached to bug # 122102 which was incorporated
into the work on bug # 106695, but work on 106695 seems to have... ah... "stalled".

OK then, since 122102 now deals solely with how to get a resizable sheet's
growbox to appear, let's use THIS bug for the original patch... at least, we can
get that in for 1.0

Comment 5

[Robert John Churchill]

Attachment: Same gool ol' patch to enable resizable sheets, sans grow box (bug # 122102)

Pink and Simon, care to review?

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 73930 [details] [diff] [review]
Same gool ol' patch to enable resizable sheets, sans grow box (bug # 122102)

sr=sfraser

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 73930 [details] [diff] [review]
Same gool ol' patch to enable resizable sheets, sans grow box (bug # 122102)

r=pink.

ew, this block of code is using 4-space indenting. can you put it back to
2-spaces per indent to match the rest of the file?

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 73930 [details] [diff] [review]
Same gool ol' patch to enable resizable sheets, sans grow box (bug # 122102)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Robert John Churchill]

Fixed.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with build:

2002-03-14-08 on Mac OS X 10.1.3

I now am able to resize the dialog (without the grow box, as mentioned in bug
122102).