1221090 - TEST-UNEXPECTED-ERROR | test_safe_browsing_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages | TimeoutException: TimeoutException: Timed out after 30.1 seconds

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Traceback (most recent call last):
File "c:\jenkins\workspace\mozilla-aurora_functional\venv\lib\site-packages\marionette\marionette_test.py", line 313, in run
testMethod()
File "c:\jenkins\workspace\mozilla-aurora_functional\venv\Lib\site-packages\firefox_ui_tests\functional\security\test_safe_browsing_warning_pages.py", line 58, in test_warning_pages
self.check_report_button(unsafe_page)
File "c:\jenkins\workspace\mozilla-aurora_functional\venv\Lib\site-packages\firefox_ui_tests\functional\security\test_safe_browsing_warning_pages.py", line 93, in check_report_button
lambda mn: mn.execute_script('return document.readyState == "complete";')
File "c:\jenkins\workspace\mozilla-aurora_functional\venv\lib\site-packages\marionette_driver\wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.1 seconds

Checking the screenshot I can see that Firefox is waiting on SUMO for loading something from geo.mozilla.org which is not responding. I think we should not wait for readyState `complete` but `DOMContentLoaded`.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So as long as we cannot register an event listener (1121702) or have a better way to control page loads via Marionette, we cannot only listen for `DOMContentLoaded`. Reason is that the `complete` event can be fired right away and letting Marionette not see it. This would cause a hang. It means that we have to check both events.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Github PR

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged the PR to mozilla-central as:
https://github.com/mozilla/firefox-ui-tests/commit/c976c3ebd298a6b47182dbe5cd11e041b0725f11

I will backport this patch tomorrow.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All looks fine and the failure is not visible at least in the last two days. So lets get this backported for stability.

https://github.com/mozilla/firefox-ui-tests/commit/4a5b2919fd0a8c5f7b49c723bc72066ab76bb0bb (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/bd4bac2ac43f5dfa9ac34b572fa2a8be6df06cba (beta)
https://github.com/mozilla/firefox-ui-tests/commit/d2124173a58a1a90ad49765af2e66bc45164f670 (release)
https://github.com/mozilla/firefox-ui-tests/commit/26e10294a0232e9d496b03d0815f2ddaf2e04d6a (esr38)