122110 - running checksetup as non-root fails if file permissions aren't right

Status: RESOLVED DUPLICATE of bug 190188

(Bugzilla :: Installation & Upgrading, defect, P3)

Description

[Christian Reis]

While testing bug 87398, I noticed that, if file permissions are set in a closed
fashion (6x0 owner root in my case), running checksetup as non-root breaks
miserably because of file permissions that prohibit reads. I noticed problems on
the following files:

- localconfig 


print on closed filehandle main::FILE at ./checksetup.pl line 275 (#1)
    
    (W) The filehandle you're printing on got itself closed sometime before now.
    Check your logic flow.

(additionally prints wrong line for "variables are new to localconfig" and
reports that there are some variables i may want to change)

- data and data/webdot and data/webdot/.htaccess

print on closed filehandle main::HTACCESS at ./checksetup.pl line 637 (#1)
    
    (W) The filehandle you're printing on got itself closed sometime before now.
    Check your logic flow.


The proper permissions should be checked before running.

There could be other problems, but those are the ones I noticed. All files we
try and open should have a fail clause that complains about permissions
problems, in theory.

Comment 1

[Andreas Franke (gone)]

Does this mean that I will have problems if I'm running checksetup.pl as user
'bugzilla' and all files are owned by this 'bugzilla' user? If this will fail,
then this bug is a blocker for me. Otherwise, sorry about the noise.

Comment 2

[Christian Reis]

It means you will have problems running checksetup.pl as user bugzilla and all
files are _NOT_ owned by user bugzilla. Is this your case?

It will never work (checksetup.pl setuid excepted) but checksetup.pl definitely
shouldn't break apart and die.

Comment 3

[Andreas Franke (gone)]

Ok, I have updated to the tip, and checksetup.pl still worksforme. :-)

Comment 4

[Matthew Tuck [:CodeMachine]]

I think we currently handle this with a warning but we should probably change
this to error/no error depending on whether it actually needs to update any
permissions.

Comment 5

[Max Kanat-Alexander]

Oh, I've seen this kind of stuff happen on landfill when I try to run checkseutp
on an installation that I don't own (it's very weird). I'll take this.

Comment 6

[Max Kanat-Alexander]

*** This bug has been marked as a duplicate of 190188 ***