87398 - checksetup.pl should warn if not run as root.

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Matthew Tuck [:CodeMachine]]

The localconfig clearly states that if you have a web server group set, you need
to run checksetup.pl as root to chown the files.

However, if you run it not as root, it does not give you a warning in this
situation.  It should do so.

Comment 1

[Dave Miller [:justdave]]

In the interest of getting 2.14 out quicker, I'll leave this at 2.16, but this is 
a nasty oversight, and deserves prompt attention in 2.16

Comment 2

[Jacob Steenhagen]

-> New Bugzilla Product

Comment 3

[Matthew Tuck [:CodeMachine]]

It only needs to complain if there's file owners to update.  If they're already
correct we shouldn't complain.

Comment 4

[Zach Lipton [:zach]]

Attachment: Patch to fix

Comment 5

[Zach Lipton [:zach]]

Note that the patch I just attached gives a warning if there are files to 
update or not. There is no way to tell if files need updating or not with the 
current code and while I am planning a rewrite of the --CHMOD-- code of 
checksetup.pl (and possibly of all of the installation system if all goes as 
planned) there is not much reason to refactor it now. In the meantime, a 
warning should be ok.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 59264 [details] [diff] [review]
Patch to fix

The patch is full of junk characters and does not apply.

===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v
retrieving revision 1.111
diff -u -2 -r1.111 checksetup.pl
--- checksetup.pl	2001/11/27 00:49:26	1.111
+++ checksetup.pl	2001/11/27 01:20:29
@@ -727,4 +727,10 @@

 if ($my_webservergroup) {
+    unless ($< == 0) { # [e-mail]: if they are not root we need to
yell at them, bug = 87398
+	 print "Warning, you are not running this script as root and have set
the webservergroup setting\n";
+	 print "in localconfig. This can cause permissions problems and
decreased security.\n";
+	 print "If you are having problems, either log in as root and re-run
this script or un-set the\n";
+	 print "webservergroup in localconfig\n";
+    }

This should be wrapped at <80 characters for standard-sized terminal displays.

Also, may I humbly suggest the following wording:

---
Warning: you have entered a value for the "webservergroup" parameter 
in localconfig, but you are not running this script as root.
This can cause permissions problems and decreased security.  If you 
experience problems running Bugzilla scripts, log in as root and re-run
this script, or remove the value of the "webservergroup" parameter.
---

Comment 7

[Zach Lipton [:zach]]

Attachment: Patch v2

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 64459 [details] [diff] [review]
Patch v2

technically you can also run checksetup.pl as any user that's a member of
$webservergroup, but there's no real easy cross-platform way to test for
that...  so this will probably do.

Comment 9

[Zach Lipton [:zach]]

Attachment: patch v3

Fix the long comment problem

Comment 10

[Christian Reis]

Comment on attachment 66684 [details] [diff] [review]
patch v3

r=kiko

There is a problem, however , when running checksetup as non-root many problems
show up if file permission problems appear. I have filed bug 122110 on this
matter.

If you see fit, set dependents accordingly. I didn't.

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 66684 [details] [diff] [review]
patch v3

r= justdave

Comment 12

[Zach Lipton [:zach]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.117; previous revision: 1.116
done