1221102 - Turn on e10s mochitest-gl on Windows 7

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

Latest try run shows this is green on both debug and opt:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f439ce85793b

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Enable mochitest-gl-e10s on Windows 7 on trunk,

Comment 2

[Jonathan Griffin (:jgriffin)]

Builders added:
+ Windows 7 32-bit b2g-inbound debug test mochitest-gl-e10s
+ Windows 7 32-bit b2g-inbound opt test mochitest-gl-e10s
+ Windows 7 32-bit b2g-inbound pgo test mochitest-gl-e10s
+ Windows 7 32-bit fx-team debug test mochitest-gl-e10s
+ Windows 7 32-bit fx-team opt test mochitest-gl-e10s
+ Windows 7 32-bit fx-team pgo test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-central debug test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-central opt test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-central pgo test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-inbound debug test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-inbound opt test mochitest-gl-e10s
+ Windows 7 32-bit mozilla-inbound pgo test mochitest-gl-e10s
+ Windows 7 32-bit try debug test mochitest-gl-e10s
+ Windows 7 32-bit try opt test mochitest-gl-e10s

Comment 3

[Jonathan Griffin (:jgriffin)]

Will need a Treeherder patch as well.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8682504 [details] [diff] [review]
Enable mochitest-gl-e10s on Windows 7 on trunk,

Review of attachment 8682504 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, just one question- you can address it if necessary and r=me.

::: mozilla-tests/config.py
@@ +615,5 @@
> +        'use_mozharness': True,
> +        'script_path': 'scripts/desktop_unittest.py',
> +        'extra_args': ['--mochitest-suite', 'mochitest-gl', '--e10s'],
> +        'blob_upload': True,
> +        'script_maxtime': 12000,

do we need 12000 as the maxtime?  I would think 1800 (30 minutes) would be better suited.

Comment 5

[Jonathan Griffin (:jgriffin)]

(In reply to Joel Maher (:jmaher) from comment #4)
> Comment on attachment 8682504 [details] [diff] [review]
> Enable mochitest-gl-e10s on Windows 7 on trunk,
> 
> Review of attachment 8682504 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> looks good, just one question- you can address it if necessary and r=me.
> 
> ::: mozilla-tests/config.py
> @@ +615,5 @@
> > +        'use_mozharness': True,
> > +        'script_path': 'scripts/desktop_unittest.py',
> > +        'extra_args': ['--mochitest-suite', 'mochitest-gl', '--e10s'],
> > +        'blob_upload': True,
> > +        'script_maxtime': 12000,
> 
> do we need 12000 as the maxtime?  I would think 1800 (30 minutes) would be
> better suited.

Good point; I copy/pasted that from the non-e10s version, but that maxtime seems way too long. I agree with 1800s.

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: Enable mochitest-gl-e10s on Windows 7 on trunk,

Updated script_maxtime to 1800s

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8683628 [details] [diff] [review]
Enable mochitest-gl-e10s on Windows 7 on trunk,

Carry r+ forward

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8683628 [details] [diff] [review]
Enable mochitest-gl-e10s on Windows 7 on trunk,

https://hg.mozilla.org/build/buildbot-configs/rev/c209fe73999f

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

this is failing in production, we need to set the config properly, I ran into this issue whilst doing  the m-oth -> a11y, chrome*.  Here is the patch I used:
https://bug1211889.bmoattachments.org/attachment.cgi?id=8680242

in this case we would need a gl-e10s:
http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config.py#l878

and for all the platforms we care about, right now that is windows 7.  I can pick this up shortly

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add a config file option to mochitest e10s gl for windows 7 only

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/buildbot-configs/rev/ff6d9da53ad9

Comment 12

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/ff6d9da53ad9

Comment 13

[Jonathan Griffin (:jgriffin)]

Looks like this is working now; thanks for the fix jmaher!