Closed Bug 1221106 Opened 5 years ago Closed 5 years ago

Let Permissions API ride the trains

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed

People

(Reporter: poiru, Assigned: poiru)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

This was never enabled for non-Nightly. We should do so after fixing bug 1105827.

Intent to ship thread: https://lists.mozilla.org/pipermail/dev-platform/2015-August/011466.html
What's the status here?
(In reply to Marco Castelluccio [:marco] from comment #1)
> What's the status here?

I'll have patches up for this and bug 1221104 soon.
Attachment #8699476 - Flags: review?(amarchesini)
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
What about if we do 1 release cycle just enabling the pref. Then we remove it completely.
Flags: needinfo?(birunthan)
(In reply to Andrea Marchesini (:baku) from comment #4)
> What about if we do 1 release cycle just enabling the pref. Then we remove
> it completely.

Sure.
Attachment #8699476 - Attachment is obsolete: true
Attachment #8699476 - Flags: review?(amarchesini)
Flags: needinfo?(birunthan)
Attachment #8699859 - Flags: review?(amarchesini)
Comment on attachment 8699859 [details] [diff] [review]
Let Permissions API ride the trains

Review of attachment 8699859 [details] [diff] [review]:
-----------------------------------------------------------------

Good! and file a follow up to remove the pref completely, but in the next release cycle. Thanks!
Attachment #8699859 - Flags: review?(amarchesini) → review+
Blocks: 1233702
https://hg.mozilla.org/mozilla-central/rev/541be3cffed3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You flipped the pref, but didn't update http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1#925 so that test is going to fail when this merges to aurora.
https://hg.mozilla.org/integration/mozilla-inbound/rev/77a5afd82c63be762af14902439eb62b382ea59c
Bug 1221106 - Follow-up: Fix future test_interfaces.html failure for Permission{s,Status} interfaces. r=baku
(In reply to Phil Ringnalda (:philor) from comment #10)
> You flipped the pref, but didn't update
> http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/
> test_interfaces.html?force=1#925 so that test is going to fail when this
> merges to aurora.

Excellent catch, thanks! I committed a fix (and lied about "r=baku").
I fixed the version on the support table at https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#Browser_Support which initially said Fx45.
(In reply to Matthew N. [:MattN] (behind on bugmail) from comment #14)
> I fixed the version on the support table at
> https://developer.mozilla.org/en-US/docs/Web/API/
> Permissions_API#Browser_Support which initially said Fx45.

Thanks for leading the charge on getting this updated, Matt. I've followed up on this by updating the permissions on these pages (and their member subpages where relevant):

https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator
https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Permissions
https://developer.mozilla.org/en-US/docs/Web/API/PermissionStatus

I've also added a note to the relevant release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/46#Miscellaneous

Let me know if anything looks untoward. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.