If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Let Permissions API ride the trains

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: poiru, Assigned: poiru)

Tracking

({dev-doc-complete})

Trunk
mozilla46
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
This was never enabled for non-Nightly. We should do so after fixing bug 1105827.

Intent to ship thread: https://lists.mozilla.org/pipermail/dev-platform/2015-August/011466.html
What's the status here?
(Assignee)

Comment 2

2 years ago
(In reply to Marco Castelluccio [:marco] from comment #1)
> What's the status here?

I'll have patches up for this and bug 1221104 soon.
(Assignee)

Comment 3

2 years ago
Created attachment 8699476 [details] [diff] [review]
Let Permissions API ride the trains
Attachment #8699476 - Flags: review?(amarchesini)
(Assignee)

Updated

2 years ago
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
What about if we do 1 release cycle just enabling the pref. Then we remove it completely.
Flags: needinfo?(birunthan)
(Assignee)

Comment 5

2 years ago
Created attachment 8699859 [details] [diff] [review]
Let Permissions API ride the trains

(In reply to Andrea Marchesini (:baku) from comment #4)
> What about if we do 1 release cycle just enabling the pref. Then we remove
> it completely.

Sure.
Attachment #8699476 - Attachment is obsolete: true
Attachment #8699476 - Flags: review?(amarchesini)
Flags: needinfo?(birunthan)
Attachment #8699859 - Flags: review?(amarchesini)
Comment on attachment 8699859 [details] [diff] [review]
Let Permissions API ride the trains

Review of attachment 8699859 [details] [diff] [review]:
-----------------------------------------------------------------

Good! and file a follow up to remove the pref completely, but in the next release cycle. Thanks!
Attachment #8699859 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 7

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2caa17e29515
(Assignee)

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/541be3cffed34161fd6555d960320f7b7f933895
Bug 1221106 - Let Permissions API ride the trains. r=baku
(Assignee)

Updated

2 years ago
Blocks: 1233702

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/541be3cffed3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You flipped the pref, but didn't update http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1#925 so that test is going to fail when this merges to aurora.
(Assignee)

Comment 11

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/77a5afd82c63be762af14902439eb62b382ea59c
Bug 1221106 - Follow-up: Fix future test_interfaces.html failure for Permission{s,Status} interfaces. r=baku
(Assignee)

Comment 12

2 years ago
(In reply to Phil Ringnalda (:philor) from comment #10)
> You flipped the pref, but didn't update
> http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/
> test_interfaces.html?force=1#925 so that test is going to fail when this
> merges to aurora.

Excellent catch, thanks! I committed a fix (and lied about "r=baku").

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/77a5afd82c63
I fixed the version on the support table at https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#Browser_Support which initially said Fx45.
status-firefox45: affected → wontfix
Keywords: dev-doc-needed
(In reply to Matthew N. [:MattN] (behind on bugmail) from comment #14)
> I fixed the version on the support table at
> https://developer.mozilla.org/en-US/docs/Web/API/
> Permissions_API#Browser_Support which initially said Fx45.

Thanks for leading the charge on getting this updated, Matt. I've followed up on this by updating the permissions on these pages (and their member subpages where relevant):

https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator
https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Permissions
https://developer.mozilla.org/en-US/docs/Web/API/PermissionStatus

I've also added a note to the relevant release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/46#Miscellaneous

Let me know if anything looks untoward. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.