1221106 - Let Permissions API ride the trains

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Biru [:poiru]]

This was never enabled for non-Nightly. We should do so after fixing bug 1105827.

Intent to ship thread: https://lists.mozilla.org/pipermail/dev-platform/2015-August/011466.html

Comment 1

[Marco Castelluccio [:marco]]

What's the status here?

Comment 2

[Biru [:poiru]]

(In reply to Marco Castelluccio [:marco] from comment #1)
> What's the status here?

I'll have patches up for this and bug 1221104 soon.

Comment 3

[Biru [:poiru]]

Attachment: Let Permissions API ride the trains

Comment 4

[Andrea Marchesini [:baku]]

What about if we do 1 release cycle just enabling the pref. Then we remove it completely.

Comment 5

[Biru [:poiru]]

Attachment: Let Permissions API ride the trains

(In reply to Andrea Marchesini (:baku) from comment #4)
> What about if we do 1 release cycle just enabling the pref. Then we remove
> it completely.

Sure.

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8699859 [details] [diff] [review]
Let Permissions API ride the trains

Review of attachment 8699859 [details] [diff] [review]:
-----------------------------------------------------------------

Good! and file a follow up to remove the pref completely, but in the next release cycle. Thanks!

Comment 7

[Biru [:poiru]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2caa17e29515

Comment 8

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/541be3cffed34161fd6555d960320f7b7f933895
Bug 1221106 - Let Permissions API ride the trains. r=baku

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/541be3cffed3

Comment 10

[Phil Ringnalda (:philor)]

You flipped the pref, but didn't update http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_interfaces.html?force=1#925 so that test is going to fail when this merges to aurora.

Comment 11

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77a5afd82c63be762af14902439eb62b382ea59c
Bug 1221106 - Follow-up: Fix future test_interfaces.html failure for Permission{s,Status} interfaces. r=baku

Comment 12

[Biru [:poiru]]

(In reply to Phil Ringnalda (:philor) from comment #10)
> You flipped the pref, but didn't update
> http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/
> test_interfaces.html?force=1#925 so that test is going to fail when this
> merges to aurora.

Excellent catch, thanks! I committed a fix (and lied about "r=baku").

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77a5afd82c63

Comment 14

[Matthew N. [:MattN]]

I fixed the version on the support table at https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#Browser_Support which initially said Fx45.

Comment 15

[Chris Mills [:cmills]]

(In reply to Matthew N. [:MattN] (behind on bugmail) from comment #14)
> I fixed the version on the support table at
> https://developer.mozilla.org/en-US/docs/Web/API/
> Permissions_API#Browser_Support which initially said Fx45.

Thanks for leading the charge on getting this updated, Matt. I've followed up on this by updating the permissions on these pages (and their member subpages where relevant):

https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator
https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/permissions
https://developer.mozilla.org/en-US/docs/Web/API/Permissions
https://developer.mozilla.org/en-US/docs/Web/API/PermissionStatus

I've also added a note to the relevant release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/46#Miscellaneous

Let me know if anything looks untoward. Thanks!