1221118 - Cache blurred favicon image and fade it on first load for Top Sites

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stephan Leroux [:sleroux]]

As part of the profiling done on https://bugzilla.mozilla.org/show_bug.cgi?id=1220798, the blurring of the favicon image is taking up significant resources/time for each cell. It looks like this is contributing to the slight delay of the top site cells from appearing. We should be only running the blur once when we receive the favicon and cache the result until the favicon changes.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1215

First pass at moving the blur off the main thread, into the background, with some memory caching for easier invalidation. Also added in a slight fade in effect for first load of background favicons.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8682538 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1215

Slightly concerned that touching UIImages off the main thread could have some undesirable side effects, so we should be on the lookout for any regressions.

Comment 3

[Stephan Leroux [:sleroux]]

Want to wait for 2.0 for this? It's not critical.

Comment 4

[Darrin Henein [:darrin]]

Comment on attachment 8682538 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1215

This feels really snappy and I love the fade-in of the blur when it becomes available.

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Stephan Leroux [:sleroux] from comment #3)
> Want to wait for 2.0 for this? It's not critical.

Would we be able to get it into a TF build soon? 1.2 would be nice given the perf wins, but I'd feel a lot better if we could get some testing first.

Comment 6

[Stephan Leroux [:sleroux]]

I know we just did a TF yesterday but I can land this for the next one. If we don't have enough time to test it it's an easy patch to back out.

Comment 7

[Stephan Leroux [:sleroux]]

Merged

0bbdef0de6d4eed8a21b44e0dab333735118c812