1191058 - [meta] Performance issues with tiles on top-sites panel (about:home)

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Aaron Train [:aaronmt]]

Currently there are visible performance issues on the top-sites panel that affect the responsiveness of the application. The overall dips in frame-rate and UI responsiveness can be seen either filling up the panel with a Sync or by manual browsing 

The above is filed against testing on my iPhone 6 (8.3)

* Notice a large dip in frame-rate after a device rotation on about:home (compare against any other application)

* Notice a large dip in frame-rate and responsiveness when deleting a bunch of top-sites in a row; when all tiles are removed things naturally speed up (visible via animation) 

Currently the panel is very taxing on the hardware.

Comment 1

[Stephan Leroux [:sleroux]]

I can run a quick profile on it but I would put my money on the blurs as they are computationally expensive to render. Just curious, how important is it to use blurring instead of a flat or alpha faded color?

Comment 2

[Darrin Henein [:darrin]]

Getting the right color from the favicons proved tricky, and less reliably well than the blurred version. Can we cache the blurred image so we only generate it once per favicon (favicons aren't likely to change often...)

Comment 3

[Stephan Leroux [:sleroux]]

Ya good idea - we can take a snapshot of the rendered blur and use that instead of dynamically blurring it since we don't need dynamic blurring.

Comment 4

[Stephan Leroux [:sleroux]]

Add perf test for timing on blur render

Comment 5

[Stephan Leroux [:sleroux]]

I know there was some discussion going on last Friday about which approach to take with this bug. NI'ing

Comment 6

[Richard Newman [:rnewman]]

I think we're done with this for v1, now we've killed the background blur. Punting to 1.x.

Comment 7

[Aaron Train [:aaronmt]]

Still reproducible without background blur, especially seen on rotation

Comment 8

[Aaron Train [:aaronmt]]

What's incomplete about this?

Comment 9

[Richard Newman [:rnewman]]

Stefan and I considered this "just about fixed enough but not going to be acted on further unless someone screams", which is the definition of INCOMPLETE.

Comment 10

[Aaron Train [:aaronmt]]

This is even more noticeably worse on iOS9 IMO.

Comment 11

[Aaron Train [:aaronmt]]

No patch here, re-opening

Comment 12

[Aaron Train [:aaronmt]]

This also causes a terrible drop in frames when cycling through open applications on ones device and passing by Firefox on about:home, the application listing slows down to a crawl.

Comment 13

[Stephan Leroux [:sleroux]]

So interesting note: Yesterday we were talking about how when in the application switcher, the app is showing a screenshot instead of the actual app. Well this morning while using the messages app, I definitely saw the UI update while in the app switcher so I think that while in the switcher after being in Firefox we are rendering the blurs and everything which would cause the performance hit.

Comment 14

[Stephan Leroux [:sleroux]]

I'm going to start chipping away at some of the smaller sub-bugs to see if we can get something in for 1.1

Comment 15

[Stephan Leroux [:sleroux]]

Removing 1.1+ tracking since this meta won't be completed for 1.1 and is scheduled for 2.0

Comment 16

[Stephan Leroux [:sleroux]]

Majority of this bug is complete with the blur fixes. Micro perf improvement can be found here: https://bugzilla.mozilla.org/show_bug.cgi?id=1220798